•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14197-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14197-1 21 Nov 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14197-1 21 Nov 2022

We are changing the step limit on a control so I would expect an output.

DG-DEN-14000-1 21 Nov 2022

This is a normal message - should be up above the test (dialin) messages.

DG-DEN-14316-1 21 Nov 2022

Alignment

DG-DEN-14316-1 21 Nov 2022

Alignment

HD-DEN-14344-3 22 Nov 2022

Need function header.

HD-DEN-15367-1 12 Jun 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 02 Dec 2022

Please add comment.

CS-BUILD-0-2-4-1 14 Dec 2022

@param and @return.

HD-DEN-14344-5 05 Dec 2022

This might be better, with the complex conditional replaced with a temporary boolean (8.11.24)

DIALIN-DEN-17093-1 31 Oct 2024

I guessed so.
But it is always a good idea of having something to get out of the loop.
But needs a bigger discussion.

RESOLVED.

DIALIN-DEN-14001-1 08 Dec 2022

Needs @publish with message variables.

DIALIN-DEN-14001-1 08 Dec 2022

Remove extra blank line.

DD-LEAH-225-1 16 Oct 2024

Drain pump has minimum speed condition. Will reevaluate with the actual hardware once.

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED.

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED.

DD-LEAH-225-1 16 Oct 2024

Done.

HD-DEN-17093-1 21 Oct 2024

Need a default case or change switch statement to a compound if statement.

HD-DEN-17093-1 21 Oct 2024

Just pushed.

DD-LEAH-225-1 16 Oct 2024

looks the low-level monitoring of speed, current and directions are coupled with the pumps state machines. When the pump is in OFF state, you expect certain speed and current, raise alarm if they are not in range and same way for ramp and control state as well. Will Re-evaluate in future the possibility of separation.

HD-DEN-17093-1 22 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14007-1 15 Dec 2022

Use float literals.

HD-DEN-14007-1 15 Dec 2022

Add "in ms" to comment.

DG-DEN-14316-1 30 Nov 2022

Think the deleted def is correct.

HD-DEN-14307-1 19 Dec 2022

Update function header.

CS-BUILD-0-2-4-1 12 Dec 2022

Please be consistent and rename the file to ui_cs_message.py like has been done with ui_cs_request_handler.py.

HD-DEN-17093-1 31 Oct 2024

Once reservoir switch occurs, do we have to wait until the "fresh" dialysate from new reservoir reaches the BLD?

CS-BUILD-0-2-4-1 14 Dec 2022

Magic numbers.

CS-BUILD-0-2-4-1 14 Dec 2022

Times are being multiplied by 1000 in a lot of places (magic number?). Are we converting seconds to milliseconds? I think replacing 1000 with a well named constant would help clarify.

TD-LEAH-51-1 28 Oct 2024

Message payload length check to be considered.

TD-LEAH-51-1 28 Oct 2024

payload length check.

HD-DEN-17093-1 01 Nov 2024

Done.

DD-LEAH-236-1 08 Nov 2024

testConcentratePumpParkRequestOverride - this function helps to stop the pump (if it is running) and park the pumps (based on the request).

HD-DEN-17093-1 01 Nov 2024

Blank line between break and next case.

TD-LEAH-51-1 01 Nov 2024

Please comment comparing the previous macros in .c file.

RO-LEAH-244-1 30 Oct 2024

This should probably be moved to OperationModes.c and called by the generic message handling function that uses the function look-up table.

DD-LEAH-236-1 10 Nov 2024

That function allows you to stop and park the pump but I don't think it allows you to stop and not park the pump.

DD-LEAH-236-1 11 Nov 2024

Done.

DD-LEAH-236-1 11 Nov 2024

Done.

DD-LEAH-236-1 11 Nov 2024

Done.

DD-LEAH-236-1 14 Nov 2024

Remove extra blank line.

LEAHI-DIALIN-LEAH-142-2 18 Nov 2024

Fixed. Thanks!

LEAHI-DIALIN-LEAH-142-2 18 Nov 2024

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-2 19 Nov 2024

Do we need to update these channels naming/id per leahi changes?

RO-LEAH-250-1 19 Nov 2024

It is more general than that. We will be reading all feedback registers that FPGA provides. In this case, a read-back of the PWM and the measured speed for both the RO and the optional booster pump.

RO-LEAH-250-1 19 Nov 2024

Can we add the headers for all these below functions.

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

Error counter -> Integer type.