•  

Comment Results

Review Name Created Custom Fields Content
RO-LEAH-244-1 04 Nov 2024

RO FaultMode

RO-LEAH-244-1 04 Nov 2024

RO alarm fault.

RO-LEAH-244-1 05 Nov 2024

Done

RO-LEAH-244-1 04 Nov 2024

TD specific.

RO-LEAH-244-1 04 Nov 2024

Mentioning as HD fault. May need to change as DD/RO fault.. DD and TD has same alarm. Need to see how to differentiate between those and RO alarms?

DD-LEAH-236-1 08 Nov 2024

Can start/stop be handled in single Dialin message?

DD-LEAH-236-1 08 Nov 2024

Add "F" suffix to floating point literals.

DD-LEAH-236-1 08 Nov 2024

When are you planning on implementing this? Do we need for demo?

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

need to be removed.

DD-LEAH-236-1 13 Nov 2024

Seems strange that this function is in this unit. We would not be in standby mode when this request is made. Would be more appropriate to move this function to ModeGenDialysate.

UI-LEAH-1956-2 19 Nov 2024

RESOLVED

LEAHI-DIALIN-LEAH-139-2 19 Nov 2024

There are some clean up done to init states ( removal of RTC, UV reactors, thermistors, load cell etc..) , Please refer the latest code.

RO-LEAH-250-1 19 Nov 2024

None?

RO-LEAH-250-1 19 Nov 2024

Do we want to say NUM_OF_RO_PUMPS instead of Boost pumps (since there is only one optional boost pump)?

LEAHI-DIALIN-LEAH-142-2 12 Nov 2024

HD s/b TD.

LEAHI-DIALIN-LDT-566-1 24 Jun 2025

fixed.

DD-LDT-1873-1 11 Aug 2025

If you get a chance, try to find out which message (ID) is having the CRC error and where it's coming from (which channel) and why it's failing CRC check (e.g. was a frame missing?)

DD-LDT-1873-4 26 Aug 2025

Is this the right place to close the BC valves? Maybe it should be in transitionToBalChamberFill()?
If we come back to this bypass state from delivery state, is it appropriate to close BC valves here?

DD-LDT-1873-1 11 Aug 2025

Change function name (RO to FP)?

RO-LDT-1242-1 28 Aug 2025

Add comment to right.

HD-DEN-15367-1 12 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-5 02 Dec 2022

Fixed. Thanks!

HD-DEN-15367-1 30 May 2023

Make 2nd condition similar to 1st ( != TRUE ) so any value that is not 1 will take normal path. And should this be an OR (not AND)?

HD-DEN-14344-5 02 Dec 2022

Fixed. Thanks!

HD-DEN-14344-5 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15367-1 12 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 16 Oct 2024

Removed the #define

DIALIN-DEN-14001-1 08 Dec 2022

Done.

DIALIN-DEN-14001-1 08 Dec 2022

Remove dead code.

HD-DEN-17093-1 16 Oct 2024

Focus of name and comment should be on division by 16 - not on shift.

HD-DEN-15278-1 12 Jun 2023

Add bubbleClearEnded.

HD-DEN-17093-1 16 Oct 2024

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-225-1 16 Oct 2024

Recommend U32 here.

HD-DEN-17093-1 21 Oct 2024

Done

HD-DEN-14458-1 14 Dec 2022

Done.

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 08 Dec 2022

Update function header.

RO-LEAH-244-1 02 Nov 2024

The more common code the better. We can discuss.

HD-DEN-14007-1 19 Dec 2022

Updated.

HD-DEN-14007-1 15 Dec 2022

Prefer these two statics be moved up to file level scope so these can be initialized on every transition into post treatment mode.

DG-DEN-14307-1 19 Dec 2022

Update function header.

CS-BUILD-0-2-4-1 12 Dec 2022

This file needs to be auto executed bash sscript by adding
#!/usr/bin/python3
and do the:
chmod a+x
on this file

CS-BUILD-0-2-4-1 12 Dec 2022

magic number?

CS-BUILD-0-2-4-1 14 Dec 2022

All .py files should have a file header.

HD-DEN-17093-1 22 Oct 2024

I'm not seeing that. And why isn't the exec returning a state that you assign to result?

HD-DEN-17093-1 21 Oct 2024

Not clear why you're using a ternary here. Why not a simple if status == TRUE then move on to zero state?

HD-DEN-17093-1 21 Oct 2024

Should this exec return next state that gets assigned to result here? Will we never exit zeroing before we get to complete?

HD-DEN-17093-1 22 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 22 Oct 2024

Done

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

put space.