•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-17093-1 31 Oct 2024

The drift timeout does not have an override it is the zeroing interval that has overrides.

HD-DEN-17093-1 31 Oct 2024

No it is not custom please look at systemcommmessages.

HD-DEN-17093-1 01 Nov 2024

Done.

HD-DEN-17093-1 04 Nov 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-17093-1 04 Nov 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-244-1 04 Nov 2024

This looks to be TD specific one.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

remove this and act upon the response of the doConnectWifi

LEAHI-DIALIN-LEAH-136-2 04 Nov 2024

Match DD op modes for Leahi.

RO-LEAH-244-1 05 Nov 2024

Removed them.

RO-LEAH-244-1 30 Oct 2024

These alarms should be RO (not TD).

RO-LEAH-244-1 04 Nov 2024

Remove extra blank lines.

RO-LEAH-244-1 05 Nov 2024

Looks Macro still naming DG.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

updated name to WiFiIP

RO-LDT-1809-3 11 Aug 2025

get functions return data or ovdata based on override flag value.
That makes it difficult to set the ovdata to zero if we are sending an override on top of another override.

Instead checking for data value all the time as we are assigning the ovdata to data in all set functions.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

updated to be consistent

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

remove this and these will get updated in tehe response.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

this haas been moved and renamed to _wifiAvailable

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

Please provide a description of this function.
And please always add function documentation to your functions.

Is this function help to locate the dialog under the associated IconButton?

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

yes i pushed the updated drop shadow color

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

Don't you think it would be better to move the positioning to the HeaderBarPopup.qml and let that component to adjust itself with the sent Component.rectangle?

LEAHI-APPLICATION-LDT-1788-1 12 Aug 2025

RESOLVED.

DD-LDT-1873-1 13 Aug 2025

Done.

LEAHI-APPLICATION-LDT-1596-1 13 Aug 2025

Please move this to the Colors.qml

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED

RO-LDT-1809-3 13 Aug 2025

We can remove this instead of commenting it out

HD-DEN-14344-5 02 Dec 2022

Not clear on what this refactoring of condition changed - looks the same.

DIALIN-DEN-14001-1 08 Dec 2022

Done.

DIALIN-DEN-14001-1 08 Dec 2022

RESOLVED.

DG-DEN-15367-1 12 Jun 2023

The check against nearly zero is pointless since we're looking for > 10 mL/min now.
Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking against low speed threshold.

HD-DEN-14458-1 14 Dec 2022

Done.

HD-DEN-17093-1 16 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 14 Dec 2022

Done.

HD-DEN-17093-1 16 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 14 Dec 2022

RESOLVED in CODE WALKTHROUGH.

LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

Need to pass in TMP to this function now.

HD-DEN-17093-1 31 Oct 2024

I thought this was going to be an indexed override like when you have an array of temp sensors and the index gives you the enum of the temp sensor you want to override. You have a BOOL flag instead. Does that mean you're using a custom payload instead of the array override payload?

DD-LEAH-225-1 16 Oct 2024

Merged two stop functions.

HD-DEN-17093-1 21 Oct 2024

RESOLVED in CODE WALKTHROUGH.

UI-DEN-14294-1 19 Dec 2022

Align "=".

HD-DEN-14007-1 15 Dec 2022

Use float literals (e.g. 1 s/b 1.0F).

DG-DEN-14316-1 19 Dec 2022

No response sent if not in idle standby mode?

CS-BUILD-0-2-4-1 12 Dec 2022

Please don't use any magic numbers and define a variable for each to give it a meaning and definition.

HD-DEN-17093-1 21 Oct 2024

Done

LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

Remove blank line.

HD-DEN-17093-1 22 Oct 2024

The state machine that is in charge of receiving the response back from the sensor has a timeout and sets the command response as ready.

RO-LEAH-244-1 02 Nov 2024

Done

TD-LEAH-51-1 25 Oct 2024

Valves broadcast

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

updated to use check blocks instead