•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-17093-1 21 Oct 2024

Can we just set the state and that's all we need? Look at saline bolus initiation. A quick look by me suggests we should be initiating a pressure stabilization period, for example, because bypassing the dialyzer is going to likely change the venous pressure and potentially trigger a low/high venous pressure alarm. Also, what about UF pause? We need to pause UF before starting zero process. And if UF already paused, we need to record that so that when we're done we will remember not to resume UF. There may be other things too, so take a close look at saline bolus.

RO-LEAH-244-1 04 Nov 2024

RO doesnt need these.

HD-DEN-17093-1 31 Oct 2024

Done

HD-DEN-17093-1 01 Nov 2024

default should come last.

RO-LEAH-244-1 04 Nov 2024

Done

RO-LEAH-244-1 04 Nov 2024

Do you mean DD?

LEAHI-DIALIN-LEAH-136-2 04 Nov 2024

td_defs.

LEAHI-DIALIN-LEAH-136-2 04 Nov 2024

No accelerometer in Leahi.

RO-LEAH-244-1 30 Oct 2024

Why is #define name so long? Why not just MODE_STANDBY_H? Do we want to make a team decision to show the whole path in these names? I've been just doing the unit name w/o path.

RO-LEAH-244-1 30 Oct 2024

Remove extra blank line.

RO-LEAH-244-1 30 Oct 2024

Need bare minimum FPGA get/set functions to operate valves and pump.

DD-LEAH-236-1 08 Nov 2024

Fix indent.

DD-LEAH-236-1 11 Nov 2024

Done.

DD-LEAH-236-1 08 Nov 2024

Need to handle situation where switching time arrives and pressure has not yet indicated fill completed (alarm/fault).

DD-LEAH-236-1 14 Nov 2024

Indent function name more to align like others.

DD-LEAH-236-1 14 Nov 2024

Done.

DD-LEAH-236-1 14 Nov 2024

Done.

LEAHI-DIALIN-LEAH-139-2 19 Nov 2024

Please refer latest DD_defs.h for updates/clean up.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

make this one dns

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

get the ssid from this response.

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

updated

DG-DEN-14253-1 05 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-5 02 Dec 2022

Remove blank line.

HD-DEN-14344-5 05 Dec 2022

Restore this blank line.

LEAHI-DIALIN-LEAH-142-2 12 Nov 2024

HD s/b TD.

DIALIN-DEN-14001-1 08 Dec 2022

Needs @publish with message variables.

DIALIN-DEN-14001-1 08 Dec 2022

I believe Dong Nguyen created this module (in 2022).

DIALIN-DEN-14001-1 08 Dec 2022

Functions need headers.

HD-DEN-17093-1 16 Oct 2024

Removed it

HD-DEN-17093-1 16 Oct 2024

I don't think we need this field (been set). It will always be set.

HD-DEN-17093-1 16 Oct 2024

upper and lower limits of range are BLD_NOMINAL_INTENSITY - ( setPoint * BLD_XXX_INTENSITY_OUT_OF_RANGE ).

HD-DEN-15367-1 12 Jun 2023

Should choose to either align on "=" or use " = ".

HD-DEN-17093-1 16 Oct 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14458-1 14 Dec 2022

Done.

HD-DEN-14458-1 14 Dec 2022

Should be absolute value (in case measMotorSpeedInRotorRPM is negative for reverse direction).

DD-LEAH-225-1 16 Oct 2024

Added separate pump coefficients. The pump coefficients to be finetuned once we get more information on the pump speed/PSI relationship.

HD-DEN-14007-1 13 Dec 2022

Update function header.

DIALIN-DEN-14316-1 19 Dec 2022

Should add chem flush = 11 to this enum.

CS-BUILD-0-2-4-1 14 Dec 2022

Classes should have a header w/ brief description.

DD-LEAH-225-1 16 Oct 2024

Added both fresh and spent dialysate alarms in comments. done.

HD-DEN-17093-1 21 Oct 2024

The state has been removed.

HD-DEN-17093-1 21 Oct 2024

RESOLVED in CODE WALKTHROUGH.

TD-LEAH-51-1 28 Oct 2024

Fixed.

HD-DEN-17093-1 21 Oct 2024

What does that have to do with my comment? Stopping the pumps will also change the pressure. Doesn't help. I'm asking you to look at and understand how the saline bolus works and follow that model more closely. I think you are missing things that we need to deal with.

HD-DEN-17093-1 21 Oct 2024

I added a static pointer to change the state inside one the exec handlers.

DG-DENBUG-276-1 21 Oct 2024

Do we what to do this in ALL fill states?

HD-DEN-17093-1 22 Oct 2024

RESOLVED in CODE WALKTHROUGH.

TD-LEAH-51-1 28 Oct 2024

Fixed.

TD-LEAH-51-1 28 Oct 2024

unit variables initialized.

UI-DEN-17098-1 24 Oct 2024

Don't we need to add the new field in its Model?