Comment Search

Why are we distinguishing between these 2 types of zeroes? Does it matter why we zeroed?

I understand your comment. I am saying stabilizing when the pumps are running might be harder as you stop in other places. I will match to saline state.

Please don't use google domain for any test.
Please use the defined knowns used URLs for the DCS, since if they are not working internet connection doesn't mean and help with anything.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Remove them.

ROFaultMode.

DD?

reverted back to original implementation to instantiate each IconButton and remove repeater

Please use the lOut as I have mentioned above, and remove repeated emits.
and move the definitions on top before the goto(s).

I think this should be specific to some dialog, not all. likethe alarm or confirm.
Please make this more specific.

good catch fixed alignement

RESOLVED

RESOLVED

Remove extra blank line.

Seems like there should be code changes in HD standby mode to handle these states. I don't see an HD code branch though.

Done

Argument numbers (magic numbers) could be clarified with well named constants.

Done.

Done.

Fixed. This condition requires that the Pump is flagged off. that same condition is also used below. we will always be true in the first condition below if we satisfy this condition. If we try to change direction when the pump is on, both this condition and the one below will fail.

Can't we just say isFlowLow = ( measFlow > minFlow ? FALSE : TRUE );

Remove dead code.

Should this exec be moved to Dialysis.c? Seems like it should be with UF and saline bolus execs that are at the same state level.

RESOLVED in CODE WALKTHROUGH.