Keep blank line.
RESOLVED IN CODE WALKTHROUGH
What is this comment for?
Remove this test code.
Alignment
conversion.py ?
Remove space
That was one the best explanations I have ever gotten about one of my confusions. I should have asked this a long time ago. Thanks a lot, Sean. RESOLVED in CODE WALKTHROUGH.
RESOLVED in CODE WALKTHROUGH.
Done.
This function will be modified in DEN-13834.
Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).
0.0F (pwm) param not in function - remove.
Put define on left of comparison. DG_MODE_HEAT != dgOp.
Are bloodLeakEmbModeHasZeroBeenRqustd and bloodLeakSelfTestStatus both global?
RESOLVED
Per Sean - "No harm in adding "F" suffix, but not necessary for assignment to a float variable". Will leave as is for float vars.
Removed.
This is here so both stacks can use it.
RESOLVED.
Voltage mis-spelled. Should rename anyway per comment above.
Remove comment.
measuredDialInFlow is (and was) local to this function, but measuredDialInFlowRate is not - it is accessed via getMeasuredDialInFlowRate().
If it's a global static variable, use variable name. If it's accessed via another module's get function, description is ok.
Remove.
Fixed. Thanks!
Dara confirmed it is a duty cycle. We expect it to match our commanded duty cycle for the pump.
Update header.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
