Comment Search

Defect Metrics

Statistics on the results
No defects in results

Search Criteria

Search for comments

Search Criteria

Project
Comment content
Review PermaId
After
Before
Comment Author
Search Type
Search Type:
Review State
Review State:
Metrics:
Metric Ranking
Metric Classification
Submit
  •  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

I guess, the common message payloads (TD <> DD, DD <> IOFP) are defined here to avoid duplicate copy in their subsystems. For instance, TD wants to know the TMP pressure value, but it's been measured in DD subsystem.

These are defined under "Messaging" group as part of doxygen grouping for now.
HD-DEN-14307-1 21 Dec 2022

Done
LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Remove blank line.
DG-DEN-14307-1 21 Dec 2022

Done
DG-DEN-14307-1 21 Dec 2022

Done
DG-DEN-15608-1 12 Jul 2023

But you can be "not in safe state" and not have the heater on (e.g. in standby mode). Is this voltage always 24V even when the heater is off?
DG-DEN-14307-1 21 Dec 2022

RESOLVED IN CODEWALKTHROUGH.
TD-LEAH-51-1 01 Nov 2024

Please add \b style formatting for inputs, outputs and alarms (entire file). Also add alarm details where needed.
DG-DEN-14307-1 21 Dec 2022

Should add alarmDetectedPendingTrigger and preFlushState.
DG-DEN-15702-1 12 Jul 2023

Corrected.
DG-DEN-14316-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.
LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Add a blank line between declarations and code.
DG-DEN-14316-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.
DG-DEN-15702-1 12 Jul 2023

Corrected.
RO-LEAH-244-1 05 Nov 2024

Removed them.
CLOUDSYNC-DEN-15279-1 17 Jul 2023

RESOLVED
RO-LEAH-244-1 30 Oct 2024

Shouldn't need a handler section since all handled messages should go through the above handleIncomingMessage() function.
HD-DENBUG-64-1 18 Jul 2023

Done
RO-LEAH-244-1 04 Nov 2024

All these TD alarms should be RO ( entire file)
HD-DENBUG-64-1 18 Jul 2023

RESOLVED in CODE WALKTHROUGH.
DIALIN-DEN-14344-1 22 Dec 2022

Fixed. Thanks!
LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Opmode functions removed?
HD-DEN-14344-3 22 Dec 2022

RESOLVED IN CODE WALKTHROUGH.
RO-LEAH-244-1 06 Nov 2024

Will resolve in next branch.
RO-LEAH-244-1 06 Nov 2024

Will resolve in next branch.
HD-DEN-14934-1 20 Jul 2023

Add resumeRinsebackRequested.
LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

added.
UI-DEN-15905-2 21 Jul 2023

"compeleted" => "completed"
DD-LEAH-236-1 11 Nov 2024

Done
DD-LEAH-236-1 08 Nov 2024

These variables are initialized in init function. No need to initialize here.
HD-DEN-15719-2 25 Jul 2023

RESOLVED IN CODE WALKTHROUGH
LEAHI-TESTSUITES-LDT-2839-1 24 Feb 2026

is this check needed? can we just click update to remove the if statement and use waitForObject?

Ex. mouseClick(waitForObject(settings_menu_object, 2000))
LEAHI-DIALIN-LEAH-142-2 18 Nov 2024

Fixed. Thanks!
LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED
UI-LEAH-1956-2 19 Nov 2024

Done
UI-LEAH-1956-2 19 Nov 2024

Please modify the following line:

    QVariantList tempForConsuming = vData; // To consume vData

to the:

    Q_UNUSED(vData);
    // or
    (void)vData;

please use the former to be consistent with Qt coding standard.
LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED
RO-LDT-566-4 12 Aug 2025

When commenting out problematic alarms (temporarily), can we at least send an event w/ same 2 datas for logging purposes so we can investigate later?
LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

done
LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

DG to DD in entire file.
LEAHI-DIALIN-LEAH-142-2 12 Nov 2024

Update to latest in staging branch.
LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

read counter -> integer type
LEAHI-TD-FIRMWARE-LDT-1840-1 12 Feb 2026

Please update the documentations too.
LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

these have been removed
LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

RESOLVED.
LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Should we just remove this whole if statement?
LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Fixed. thanks!
LEAHI-APPLICATION-LDT-2071-1 03 Sep 2025

These two need to @CAPIZED (set last byte to 0F) to avoid duplication.
LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Why are these commented out. They are in the payload, so we should set them.
LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Fixed. thanks!