Fix indent.
Need to handle situation where switch time arrives and pressure does not yet indicate fill completed.
Fix indents.
Remove extra blank line.
sizeof() for an enum will probably come back as 1 or 2 bytes depending on size of enum list. I suspect Dialin is sending a U32 (4 bytes) here.
Done.
Done. removed the state and added Execmonitor to check these parameters.
I think this if .. else if .. would be cleaner as a nested if.
HD s/b TD.
RESOLVED in CODE WALKTHROUGH.
Do we still want un-averaged TDi and TRo in this broadcast? Is anybody using them? If not, why not replace the old temps with the new averages?
removed
The lines have been moved.
Should this check be done before we ask HD to go to service mode? ie: go to service mode as the else condtion of this noCANBus check
Will handle in next revision. Not sure alarm needs to be implemented for 6th demo.
instead of this can we use a wait for object .. mouseClick(waitForObject(settings_menu_object, 2000))
RESOLVED
RESOLVED IN CODE WALKTHROUGH.
updated
Fixed.
RESOLVED.
Done
I think we still want to keep the comment. It has not been implemented yet.
Does not appear to be used.
This kind of temporary test change should probably not be committed. Just do locally in lab so reviewers don't see it and no chance that it stays this way.
There is one more -1 that considered D98. fp.conductivity.cmd_conductivity_sensor_filtered_readings_override()
RESOLVED IN CODEWALKTHROUGH.
Data is a local variable but added alarmButtonBlockers
I would use motor speed (not rotor). It takes longer for rotor speed to zero.
removed this connection
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
