Before the beginning /* Sean asked me to update your branch. I have modifications to 3 files which I believe address most of my comments. I can push my changes if that helps.
I believe you have a spelling typo here. eError_SettingNotExits or eError_SettingNotExists ?
Actually they are used.
Bruce as we had discussed, please investigate if we forking the CAN, BT, WiFI, Touchscreen helps from a startup time, i.e. the individual process could wait for a certain state to happen or you could reorder the startup sequence.
RESOLVED in CODE WALKTHROUGH.
Done.
updated to move these to response
Done
The function is up to date.
No these are only broadcast data. We do not override the states of a mode.
This was a collaboration branch. the codes here are used partially in the DEN-14733-UI-BN-S90 branch and the branch CR is complete and done.
RESOLVED IN CODEWALKTHROUGH.
Updated with publish function and overrides.
Should alarmButtonBlockers and ALARM_TABLE also be added.
FluidPump.h
RESOLVED IN CODE WALKTHROUGH.
Correct, that is for clarification since in each of the child(ish) classes in stack back and confirm have different meaning.
Add concCap and diaCap to header.
Discussion with V&V has determined that we dont need an override for the time being.
Update: I added some logic to append to the dns string if there are more than one
Fixed. Thanks!
this will automatically get corrected when the file name is changed in the file explorer of the QtCreator.
Add // 150.
RESOLVED
function names don't match.
the following is the actual CR for this story: http://devapps.diality.us:8060/cru/UI-DEN-15905-2 this one will be closed.
Align values
fixed
The trimmer heater is turned back on in the transition back to dialysis: transitionToDialysis( ) This is definitely a place I would suggest refactoring, as the trimmer heater should follow dialysate flow everywhere, but is somewhat distributed.
Comment alignment
Is this being permanently removed. I believe there is a requirement for generating this alarm.
Use 0.0F for floats.
Use "F" suffix for floats.
0.0F.
fluider pump = boost pump?
Remove 2 extra blank lines.
Remove extra spaces before ].
added comments to function and moved to HeaderBarPopup
RESOLVE
RESOLVED.
added more check blocks
Corrected.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
