•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15839-2 27 Jul 2023

This is a second, separate branch addressing this ticket, and these changes should only be in develop (for testing) at this point. Eventually, this branch should replace the branch you reverted out of staging.

stopDialysis() almost exactly mirrors the four lines I commented out, except the pump "hardstop" routines also manage the control variables that start and stop the PI controllers. This should still make zero difference to the case Nick is investigating since these changes are local to a saline bolus, which is not run at all while active ultra filtration is being run, and only affect the initial bolus state (0), while stopping the pumps. State 1, puts the pumps back into closed loop control, once the valves separate the patient, the blood and the dialysate from the dialyzer.

UI-DEN-15896-1 24 Jul 2023

Previous lines are removed

LEAHI-DIALIN-LDT-566-1 25 Jun 2025

fixed. thanks

LEAHI-DIALIN-LDT-566-1 25 Jun 2025

added logging statement

RO-LDT-566-1 25 Jun 2025

Remove extra blank line.

RO-LDT-566-1 25 Jun 2025

Copy/paste - update header.

RO-LDT-566-1 25 Jun 2025

No inputs in this function.

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

fixed

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

updated

RO-LDT-566-1 25 Jun 2025

Align comments.

DG-DEN-15702-1 13 Jul 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Let's change "index" to "alarm" for clarity.

DG-DEN-14316-1 20 Dec 2022

removed

DG-DEN-14316-1 20 Dec 2022

OK I see the space.

HD-DEN-15628-1 17 Jul 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

Update SettingsWiFi.qml to not show contents of IP Address field when there is a WiFi connection error.

UI-DEN-15279-1 17 Jul 2023

In the scripts "Yes/YES" means the default value, or the suggested value and "no", is the opposite.

DG-DEN-14307-1 21 Dec 2022

Done.

DG-DEN-14307-1 21 Dec 2022

No, it was removed by accident.

UI-DEN-15279-1 17 Jul 2023

Added

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

also added.

DG-DEN-14307-1 21 Dec 2022

Done

UI-DEN-15279-1 17 Jul 2023

RESOLVED

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1 20 Dec 2022

Remove blank lines. If nothing in else, remove else.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Should be 2 blank lines above and below test support banner.

DG-DEN-14307-1 21 Dec 2022

Done

UI-DEN-15279-1 17 Jul 2023

RESOLVED

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Align "="

DIALIN-DEN-14344-1 22 Dec 2022

RESOLVED.

UI-DEN-15279-5 17 Jul 2023

RESOLVED

DD-LEAH-236-1 14 Nov 2024

Done.

UI-DEN-15279-5 17 Jul 2023

RESOLVED

HD-DEN-15536-1 24 Jul 2023

Done

HD-DENBUG-64-1 18 Jul 2023

Correct. Alarm 126 is not blood and dialysate recirculation.

HD-DENBUG-64-1 18 Jul 2023

Should be the recovery alarm.

DD-LEAH-236-1 14 Nov 2024

Done.

HD-DENBUG-64-1 18 Jul 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-236-1 14 Nov 2024

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases.
And I don't think we should be setting result to TRUE here necessarily. If we set result to FALSE above, it should stay FALSE.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

removed this method

HD-DEN-15536-1 24 Jul 2023

Done

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

implement it in a single structure packing by moving all other pragma pack

UI-DEN-15905-2 24 Jul 2023

thank for catching that,
it has been fixed.

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

HD-DEN-15664-1 21 Jul 2023

Do we need to be able to override broadcast interval for this? I wouldn't think so. But if we do, need Dialin updated to support that.

LEAHI-APPLICATION-LDT-1536-1 12 Aug 2025

RESOLVED

HD-DEN-15844-1 19 Jul 2023

RESOLVED IN CODE WALKTHROUGH