Comment Search

heater -> Level

Error counter: float to Integer type.

add an empty line before and after

not clear what this does.
I think we should look for a FAILED keyword here.

Use "// DEBUG: " when commented out, a debug code that is kept for later use.

This I will align similar to how the others look in the AppController. The SLOT/SIGNAL keywords are aligned.

that could be a good idea,
but in lockdown we assume the application POST is passed, otherwise we cannot do the manufacturing setup.
so technically it already checked in application POST.

code alignment

RESOLVED

Please put //DEBUG

Add occlusionBaseLineWasSet

RESOLVED

this is incorrect connection usage.
it should be moved to the applicationController class.

The rule of API design:

• the API is just emitting the signal
• and is not responsible for the usage.
• any object which needs to use it will connect and use (connects the signal to its own slot and runs the logic in its own thread)

Please move to ApplicationController class.

No longer plural.

This is for stripping the output file. The I am assuming that we are running this script on the build server, which may not give us the right path. This is why the script is also asking for the "device path"

The output file looks like this:
<HASH> <current path of conf file in server>

these are combined/bundled states.
look into the cpp.
that is I added an extra _ in the name to distinguish them.

removed

RESOLVED

RESOLVED.

Approach simplified.

I am not sure what should be done.

Remove blank line.

Just pulled your latest branches and get the following warnings when I build:
Description Resource Path Location Type
#179-D function "dequeue" was declared but never referenced NVDataMgmt.c /DG/FWCommon line 2484 C/C++ Problem
#179-D function "setFillInfoToRTCRAM" was declared but never referenced ModeFill.c /DG/App/Modes line 997 C/C++ Problem
#552-D variable "chemDisinfectFlushUIState" was set but never used ModeChemicalDisinfectFlush.c /DG/App/Modes line 115 C/C++ Problem
#552-D variable "rsrvrFillStableTimeCounter" was set but never used ModeChemicalDisinfectFlush.c /DG/App/Modes line 127 C/C++ Problem
#552-D variable "R1ChemDisinfectVol" was set but never used ModeChemicalDisinfect.c /DG/App/Modes line 171 C/C++ Problem
#552-D variable "R2ChemDisinfectVol" was set but never used ModeChemicalDisinfect.c /DG/App/Modes line 172 C/C++ Problem

Needs function header.

Done. dryPressureTestsCompleted is only set when test config is active so I don't want to include that in doxygen documentation.