RESOLVED IN CODE WALKTHROUGH.
drainTimer, waitTimer
Comment says the PWM duty cycle ( 0..500). But here we check MAX_RO_PUMP_PWM as 100. Please update as needed.
RESOLVED IN CODEWALKTHROUGH.
Fixed.
RESOLVED
Done
Done. Added all *.dflt as part of the filter
removed
Could you be more specific? It looks correct to me.
Did we consider temperature as additional parameters as part of the payload?
fixed.
This may be from an older version?
Need a default case w/ s/w fault.
code alignment
Same here, baro sensor read counter as well Integer type.
please check, lists are not empty. can be checked by private member variable:
isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();
Not in this file. It is within UI proxy since that is where the method for requesting the HD version. For the DG, that method is within dialysate_generator.py.
Fixed. Thanks!
Unsure what table you are specifying. Does the current commit look correct?
Please update as required for RO.
RESOLVED in CODE WALKTHROUGH.
Keep blank line between functions.
//DEBUG, please
It can only be 0 or 1 in a U32 for the time being. I can cast it as a bool
Why was all of this necessary?
yes
Add blank line between declarations and code.
Remove blank line.
Function names don't match.
fixed
Use 0.0F for floats.
Copy/paste - update header.
I mean, for Inputs, outputs, Alarms and Message, use \b in front of it.
Remove extra blank line.
Not valve. Should be control (0=stop, 1=start).
updated this to be consistant
Align comment.
http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-1788-1CFR-69529
fault -> FALSE
Fix spacing at end of if statement.
done
Removed FPcommon.h
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
