Add occlusionBaselineWasSet, selfTestStartTime, selfTestsResumeRequested (should be selfTestResumeRequested?)
Please change this too, to WiFiIP as you did on the others.
Done.
RESOLVED in CODE WALKTHROUGH.
An empty CR with past story. Will be closed.
RESOLVED
This memset should be deleted since handled above in loop now.
Need to calculate this before filtering function above so it can be passed into the function.
RESOLVED.
I think this check needs to happen in the handler rather in the set functions. Please update MIN_RO_PRESSURE_PSI and MIN_FLUID_PUMP_DUTY_CYCLE_PCT to 0 and reflect the change in their respective set functions.
use braces for if statement
Is this intended to be a BITWISE OR? Did you intend || ?
RESOLVED IN CODE WALKTHROUGH
#define 0U across the file.
added to Colors
Please use the Colors.white ("white") for the HeaderBarPopup(s) background.
Stephen Quong Please let's do that only for the long template-based iterator types, and not for all the variables. And agree with using const and also & when applicable.
Should we range check pumpId and trigger s/w fault if out of range?
We should add a DSP for display the information to the user. everytihg start from user but we do not have a response comming back to the user.
removed
Fixed. Thanks!
It has been fixed in the new ui.scripts repository.
Actually the only other place I could put them is at the top of the function.
Do we need separate versions of this flag?
Fixed.
RESOLVED IN CODE WALKTHROUGH.
Ok as is. RESOLVED in CODE WALKTHROUGH.
R1ChemDisinfectVol and "R2ChemDisinfectVol have been removed from ModeChemicalDisinfect.c
I don't see what needs to be updated.
Fixed
Can be deleted for now, or update RO alarms and comment it for later use. the commented code appears to be DD alarms.
Prefer Dialin script writers see T/F for these. F/W sends BOOL which is essentially a U32. Just using unpack 'I' since it's best fit.
RESOLVED IN CODEWALKTHROUGH.
Alignment.
If the file is indeed incorrectly named, please also correct here
I think he meant do we need an override for the broadcast interval.
Read counter is integer type (not float).
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
