•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14316-1 20 Dec 2022

Not sure.

DD-LEAH-236-1 08 Nov 2024

Need TD dialysate deliver message handler to set params.

HD-DEN-15628-1 17 Jul 2023

Align comments.

RO-LEAH-250-1 19 Nov 2024

RO valves

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

I think even with 1 float, we should have markers to generalize handling of IOFP floats (easier if we add a float later).

DG-DEN-14316-1 20 Dec 2022

removed

UI-DEN-15896-1 24 Jul 2023

Already checked with Behrous

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15279-1 17 Jul 2023

Thanks [~vduong],
That is a very important point.
I have never thought about it.
Probably does the same for the new place but the usage percentage needs to be adjusted/reviewed.
I will create a ticket for this.

DD-LEAH-236-1 14 Nov 2024

"Valve" should be plural in these function names. Change "the all" to "all".

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15279-1 17 Jul 2023

added

UI-DEN-15279-1 17 Jul 2023

// DEBUG: needed

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DD-LEAH-236-1 14 Nov 2024

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

HD-DEN-14307-1 21 Dec 2022

Fixed the setServiceTime function. Thanks.

UI-DEN-15279-1 17 Jul 2023

RESOLVED

HD-DEN-14307-1 21 Dec 2022

Done

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Are these RO commands still relevant?

HD-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14316-1 20 Dec 2022

Is this needed for publishing data? Is this a future enhancement?

UI-DEN-15279-1 17 Jul 2023

RESOLVED

LEAHI-DIALIN-LEAH-142-2 18 Nov 2024

Fixed. Thanks!

DG-DEN-14316-1 21 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14307-1 20 Dec 2022

Should not be able to transition from heat disinfect cool to chem disinfect cool.

DG-DEN-14307-1 20 Dec 2022

Need a default case w/ comment stating status already set to TRUE for all other modes.

UI-DEN-15279-1 17 Jul 2023

added

HD-DEN-14307-1 21 Dec 2022

RESOLVED IN CODEWALKTHROUGH.

UI-DEN-15279-5 17 Jul 2023

There is a " systemctl stop <service> " That we should use instead of killall since the qt stuff is using systemctl to start.

HD-DEN-14344-3 22 Dec 2022

Fixed. Thanks!

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15279-1 17 Jul 2023

Correct, it was a typo and fixed.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-142-2 18 Nov 2024

Fixed. Thanks!

UI-DEN-15279-5 17 Jul 2023

fixed

LEAHI-DIALIN-LEAH-139-2 19 Nov 2024

Please replace all DG references to DD.

SCRIPTS-DEN-15774-1 24 Jul 2023

It has been decided we are not doing it for now.
will be asked to close.

DG-DEN-15842-1 20 Jul 2023

Blaine's comment shows discrepancy between HD and DG fan handling with these flags. Would we ever want to block an HD Fan alarm? Looks to indicate a HW fail.

RO-LEAH-250-1 19 Nov 2024

can we elaborate the function name as readBoostPumpSpeed or MeasuredSpeed ?

DG-DEN-15921-1 25 Jul 2023

This comment should say "bicarb pump is 2% faster than...." .

RO-LEAH-250-1 19 Nov 2024

RO cal records ( just change DD ->RO name for now, can be defined later)

UI-DEN-15833-4 25 Jul 2023

use braces for if statement

RO-LEAH-250-1 19 Nov 2024

priorRawLevel ( small p)

UI-DEN-15279-5 17 Jul 2023

Not related to this release, 2 secs does seem excessive. Also we need to plan on forking them out.

RO-LEAH-262-1 25 Nov 2024

pressure -> flowrate

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

updated to match the enum to the script return

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

fixed

LEAHI-APPLICATION-LDT-1021-1 29 Jun 2025
  • Indent the fields.
  • Align the =