•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14316-1 20 Dec 2022

Fixed

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

DD_SW_FAULT_ID_T

HD-DEN-15918-1 27 Jul 2023

Corrected, thank you!

DG-DEN-14316-1 20 Dec 2022

I'll have Dara do it once this branch is closed. It's a small thing on HD side to manage some UI interactions.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Remove extra blank lines.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

RO-LEAH-250-1 19 Nov 2024

I am calling both pumps a "boost" pump as a type of pump that both are. And then we have the RO pump is one boost pump and the optional booster pump is another boost pump. A little confusing I realize.

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14316-1 21 Dec 2022

Where is UI state used?

DG-DEN-14307-1 21 Dec 2022

Done

HD-DEN-15741-2 01 Aug 2023

Change simplified in TreatmentRecirc.c
Pump control changes reverted. Christina's earlier testing confirmed these worked, similar to the findings in the DEN-16016 resolution.

DG-DEN-14307-1 21 Dec 2022

Done

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14307-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-250-1 19 Nov 2024

Fixed.

DG-DEN-14316-1 21 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15833-10 28 Jul 2023

Changed

DG-DEN-14307-1 21 Dec 2022

RESOLVED IN CODEWALKTHROUGH.

RO-LEAH-250-1 19 Nov 2024

Removed check. Caller checks prior to calling this function.

DG-DEN-14316-1 21 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15918-1 28 Jul 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14344-3 21 Dec 2022

RESOLVED IN CODEWALKTHROUGH.

UI-DEN-15905-11 28 Jul 2023

Did you resolve the ^M character issue we saw yesterday in these commits too ?

DIALIN-DEN-14344-1 22 Dec 2022

Fixed. Thanks!

DIALIN-DEN-14344-1 22 Dec 2022

Fixed. Thanks!

UI-DEN-15905-12 30 Jul 2023

added

HD-DEN-14344-3 22 Dec 2022

added the function call within the end of consumable self tests when air pump is enabled.

UI-DEN-15905-12 29 Jul 2023

Please put //DEBUG

HD-DEN-15886-1 01 Aug 2023

Done.

HD-DEN-15741-2 01 Aug 2023

Comment is copy. What is this flag for? Is it user requested?

HD-DEN-15741-2 01 Aug 2023

Update header

RO-LEAH-250-1 19 Nov 2024

This duty cycle is for actual RO pump. correct (MAX_RO_PUMP_PWM_DUTY_CYCLE)? if the Boost pump has same or different duty cycle, that can be called with another macro - MAX_BOOST_PUMP_PWM_DUTY_CYCLE.

RO-LEAH-250-1 20 Nov 2024

Looks param still mentioning valves.

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

Change to Dialysate pumps (few more places referenced as Concentrate pump as well in this file)

UI-DEN-15833-10 01 Aug 2023

RESOLVED

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

Conductivity -> Pressure

RO-LEAH-262-1 25 Nov 2024

Fixed.

UI-DEN-15833-10 01 Aug 2023

Thanks for reminding me the situation with the comment.
that is right in View classes we need to.
maybe later we can move these checks all in the settings controller, from this view.

RESOLVED.

UI-DEN-15918-2 28 Jul 2023

it will be /home/denali/.config/settings.crc

UI-DEN-15905-12 01 Aug 2023

yes I did.

LEAHI-DIALIN-LEAH-139-2 26 Nov 2024

I am strongly against the idea of including/importing everything.
This is against all the modularity idea.

Imagine someone includes all the libraries in the main.cpp in a C code, does that sound a right thing to do???
Every part of the code needs that should import that.

UI-DEN-15905-12 01 Aug 2023

Fixed

UI-DEN-15905-12 01 Aug 2023

Added

UI-DEN-15905-12 01 Aug 2023

Did you intentionally left this commented out ?

UI-DEN-15905-12 02 Aug 2023

RESOLVED

RO-LEAH-262-1 25 Nov 2024

pressure -> flow

UI-DEN-15905-12 02 Aug 2023

RESOLVED

UI-DEN-15905-12 01 Aug 2023

Type in the name, reservoir missing an r

RO-LEAH-262-1 25 Nov 2024

pressure -> flow

RO-LEAH-262-1 25 Nov 2024

Fixed.