I am calling both pumps a "boost" pump as a type of pump that both are. And then we have the RO pump is one boost pump and the optional booster pump is another boost pump. A little confusing I realize.
Change simplified in TreatmentRecirc.c Pump control changes reverted. Christina's earlier testing confirmed these worked, similar to the findings in the DEN-16016 resolution.
This duty cycle is for actual RO pump. correct (MAX_RO_PUMP_PWM_DUTY_CYCLE)? if the Boost pump has same or different duty cycle, that can be called with another macro - MAX_BOOST_PUMP_PWM_DUTY_CYCLE.
Thanks for reminding me the situation with the comment. that is right in View classes we need to. maybe later we can move these checks all in the settings controller, from this view.
I am strongly against the idea of including/importing everything. This is against all the modularity idea.
Imagine someone includes all the libraries in the main.cpp in a C code, does that sound a right thing to do??? Every part of the code needs that should import that.