•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Dec 2022

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

HD-DEN-14344-3 22 Dec 2022

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 22 Dec 2022

Fixed. Thanks!

DG-DEN-15996-1 03 Aug 2023

Need to make updates to Dialin too.

HD-DEN-15741-2 03 Aug 2023

Done.

HD-DEN-15741-2 03 Aug 2023

Why are we talking about rinseback here? This is recirc sub-mode of treatment mode - not rinseback.

HD-DEN-14497-12 05 Jan 2023

Timer variable is actually a time stamp of last command being queued - variable name could be clearer.

DG-DEN-14101-1 29 Dec 2022

Remove extra blank line.

DG-DEN-14101-1 29 Dec 2022

Fix indents. Consider using /// comment above this declaration instead of inline ///< comment at end.

HD-DEN-14344-3 29 Dec 2022

Fixed. Thanks!

HD-DEN-14344-3 29 Dec 2022

Fixed. Thanks!

HD-DEN-14344-3 29 Dec 2022

For a release build, looks like we would do nothing and get stuck in this state.

HD-DEN-14344-3 29 Dec 2022

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14344-3 29 Dec 2022

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

HD-DEN-14344-3 29 Dec 2022

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14101-1 29 Dec 2022

Remove extra blank line.

HD-DEN-14086-1 05 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14086-1 05 Jan 2023

Function header updated. Assignment statements do not require alignment.

HD-DEN-14086-1 05 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14497-1 01 Jan 2023

Header needs to be updated.

DG-DEN-14497-1 01 Jan 2023

Add to header and alignment.

DIALIN-DEN-14497-1 05 Jan 2023

Is this command "embedded"? Is it redundant with generic embedded command function below? Will it go into f/w embedded command queue?

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Remove extra blank line.

HD-DEN-15918-1 28 Jul 2023

FIXED IN CODE WALKTHROUGH

UI-DEN-15905-11 28 Jul 2023

yes, I did.
that is actually the only change in here.

DG-DEN-14101-1 02 Jan 2023

Done.

UI-DEN-15905-12 30 Jul 2023

Added

DG-DEN-14101-1 02 Jan 2023

Done.

DG-DEN-14101-1 29 Dec 2022

Add dataPublishCounter, genIdleDataPublicationInterval, handleBadFillFlag, badFillState, targetFillVolumeML.

DIALIN-DEN-14197-1 02 Jan 2023

Done

LEAHI-DIALIN-LEAH-139-2 21 Nov 2024

Looks the valve names, states and entire file needs to be revisited per leahi updates.

DIALIN-DEN-14197-1 03 Jan 2023

RESOLVED.

DG-DEN-15634-1 08 Aug 2023

Fixed. Thanks!

DG-DEN-15634-1 07 Aug 2023

Add dataPublishCounter to header

HD-DEN-16088-1 02 Aug 2023

Please align the columns.

LEAHI-DIALIN-LEAH-139-2 25 Nov 2024

read counter type: Integer (not float)

DIALIN-DIAL-273-1 08 Aug 2023

RESOLVED.

HD-DEN-14086-1 05 Jan 2023

Assignment alignment in module.

HD-DEN-14086-1 05 Jan 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14497-1 01 Jan 2023

Alignment.

DIALIN-DEN-14497-1 05 Jan 2023

Class should have header.

HD-DEN-15741-2 03 Aug 2023

Done

RO-LEAH-262-1 25 Nov 2024

Done.

HD-DEN-15741-2 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15741-2 01 Aug 2023

Update header

HD-DEN-15741-2 01 Aug 2023

Update header.

RO-LEAH-262-1 25 Nov 2024

Fixed.