•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-139-2 26 Nov 2024

Please get rid of this approach for leahi, and use the utility functions that have been implemented and tested to get and correctly convert payload parameters.
this is not safe and/or fast for development or even maintainable.

RO-LDT-566-1 25 Jun 2025

Then why are they added to Dialin?

LEAHI-DIALIN-LDT-566-1 25 Jun 2025

I believe the DD piston pump is temporary for Vinay. The others are temporary as i know the are being implemented but i dont know what ID they are. They needed some value since they are coded in the ui modules and are breaking unit tests

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

Copy/paste - update header.

RO-LDT-566-1 25 Jun 2025

Remove blank line.

RO-LDT-566-1 25 Jun 2025

Function names don't match.

RO-LDT-566-1 25 Jun 2025

Add blank line before return.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Remove extra blank line.

RO-LEAH-250-1 19 Nov 2024

Fixed.

DG-DEN-14316-1 20 Dec 2022

The declarations have been moved higher, as in ModeChemicalDisinfectFlush

UI-DEN-15918-2 01 Aug 2023

RESOLVED

HD-DEN-15918-1 27 Jul 2023

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-250-1 19 Nov 2024

Fixed.

RO-LEAH-250-1 19 Nov 2024

Added.

RO-LEAH-250-1 20 Nov 2024

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14316-1 20 Dec 2022

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14307-1 21 Dec 2022

Done.

DG-DEN-14307-1 21 Dec 2022

Done

UI-DEN-15833-10 28 Jul 2023

Changed based on how GuiView handles the connection from a created-in-QML object.

DG-DEN-14307-1 21 Dec 2022

Done

DG-DEN-14316-1 20 Dec 2022

Check alignment of "=" throughout module.

UI-DEN-15833-10 28 Jul 2023

Added.

HD-DEN-14307-1 21 Dec 2022

data and alarmButtonBlockers?

UI-DEN-14294-1 21 Dec 2022

RESOLVED

UI-DEN-15833-10 28 Jul 2023

Added.

UI-DEN-15905-11 28 Jul 2023

The comment is incorrect for the params.

HD-DEN-14344-3 22 Dec 2022

Fixed?

HD-DEN-14344-3 21 Dec 2022

Remove extra blank line.

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15905-11 28 Jul 2023

RESOLVED

HD-DEN-14344-3 22 Dec 2022

RESOLVED in CODE WALKTHROUGH.

UI-DEN-15905-11 28 Jul 2023

Do we need to check that the /media/sd-card is already mounted? Or is the assumption that it's always there?

HD-DEN-15886-1 01 Aug 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15886-1 01 Aug 2023

RESOLVED IN CODE WALKTHROUGH

UI-DEN-15833-10 01 Aug 2023

RESOLVED

UI-DEN-15833-10 28 Jul 2023

please do not use else.
make it like the others on top.
Look at lines 79 - 83.
And insert it in between lines 89,90
with two empty line on top and bottom of the if block

if ( ! codition ) {
  err = ;
  LOG_ ;
  return err;
}


thanks

UI-DEN-15918-2 01 Aug 2023

RESOLVED

UI-DEN-15918-2 01 Aug 2023

RESOLVED

HD-DENBUG-62-1 02 Aug 2023

Agreed. Done.

HD-DENBUG-62-1 02 Aug 2023

Shouldn't this be calculated using the specific task interval?

HD-DEN-15741-2 03 Aug 2023

In treatment recirc, BP is turned on in the resume from stop, and patient reconnect states, .100ml/min. It seems as though the user stop should turn off both pumps.

HD-DEN-15741-2 03 Aug 2023

Agree that BP is on in the recirc state. Forget 2nd comment - focus on multiple function calls comment.

HD-DEN-15741-2 02 Aug 2023

Change postponed for further testing. No change in DialOut.
DONE.

HD-DEN-15741-2 02 Aug 2023

Change postponed for further testing. No change in BloodPumps.
Done.

HD-DEN-15741-2 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15741-2 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15741-2 03 Aug 2023

Function header says no return value and I think that should be right. Remove return here.

HD-DEN-15741-2 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15741-2 03 Aug 2023

RESOLVED in CODE WALKTHROUGH.