•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

No, the thresholds are the same except in the cleaning modes we fault and in the treatment modes we recover if possible.

DG-DEN-14497-1 11 Jan 2023

No, the thresholds are the same except in the cleaning modes we fault.

DG-DEN-14497-1 10 Jan 2023

Do we not have different clear thresholds while in cleaning modes?

DG-DEN-14497-1 11 Jan 2023

Made them different.

DG-DEN-14497-1 11 Jan 2023

No, the thresholds are the same except the cleaning modes fault.

DG-DEN-14497-1 10 Jan 2023

Does this alarm not have different clear threshold in cleaning modes?

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 10 Jan 2023

Do we not have different clear thresholds while in cleaning modes?

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

Yes, it has been updated.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DEN-14497-1 10 Jan 2023

Keep a blank line between declarations and code.

HD-DEN-14497-12 11 Jan 2023

There are many of these - not just this one.

DIALIN-DEN-14497-1 11 Jan 2023

Done

HD-DEN-14497-12 11 Jan 2023

Why are these changed back to ACK_NOT_REQUIRED?

CS-BUILD-0-2-4-1 16 Jan 2023

RESOLVED.

CS-BUILD-0-2-4-1 16 Jan 2023

RESOLVED.

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Same here.
Use multi-line assignment.

DG-DEN-14497-1 11 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15980-1 23 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-15980-1 23 Aug 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-15980-1 23 Aug 2023

This is an odd description of useShort parameter.

RO-LDT-566-1 25 Jun 2025

Dialin had some new message IDs for serial # and such. I don't see them here.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

Thanks.
RESOLVED.

RO-LEAH-1972-1 22 Jan 2025

Do we need to move this to temperature.c (like you moved it for flow sensor). We have temperature for Pressure and conductivity sensors. do we all need to move to one location?

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Remove.

DG-DEN-16280-1 24 Aug 2023

This was a specific change for this alarm (150), and the associated alarms in this routine. It appeared there were similar mode limits for temperature as well. Pressure limits were more uniquely related to valve position, I thought.

I had seen the related changes in 59, and included them in my develop build.

LEAHI-APPLICATION-LDT-1440-1 25 Sep 2025

Remove radius for progress bars with markers.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

DG to DD.

LEAHI-APPLICATION-LDT-1440-1 25 Sep 2025

Verify label position above lollipop.

HD-STT-1965-1 25 Aug 2023

Provides support for an override being programmatically reset. Override functionality only changed for getI2CStatusRegister.

DIALIN-DEN-14497-1 11 Jan 2023

what is 6?

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

HD-DENBUG-290-1 22 Jan 2025

I think "dialysate" should be "dialyzer".