•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

DG to DD.

LEAHI-APPLICATION-LDT-2160-1 12 Sep 2025

RESOLVED.

DG-DEN-15973-1 28 Aug 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-16288-1 28 Aug 2023

Did you mean to keep this commented out ?

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

done.

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

changed

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Not blood flow.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

RO-LDT-566-1 27 Jun 2025

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-2749-1 12 Feb 2026

done

RO-LDT-566-1 27 Jun 2025

Remove extra blank line.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

Please keep the attributes close together and add an empty line between those and the rest of the normal PROPERTY/READONLY properties.

    ATTRIBUTE   ( QStringList   , wifiList            , {}   , WifiList          )
    ATTRIBUTE   ( QStringList   , wifiInfo            , {}   , WifiInfo          )
    ATTRIBUTE   ( bool          , wifiConnect         , false, WifiConnect       )
    READONLY    ( bool          , wifiListEnabled     , true                     )
    READONLY    ( QString       , ssid                , ""                       )
    READONLY    ( QString       , ipAddress           , ""                       )
    READONLY    ( QString       , gateway             , ""                       )
    READONLY    ( QString       , subnetMask          , ""                       )
    READONLY    ( QString       , dns                 , ""                       )
LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025
  • I believe we discussed calling the WifiInfoRequest to update the left section of the WiFi screen.
    Therefore, the if block starting from line 577 should be removed.
  • And also discussed adding functionality to set the successfully connected SSID highlighted in the vDeviceView and avoid recalling the wifiListRequest.
LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

I don't think this is being used correctly.
Since this is an attribute, not a property, it entails more to call the script as we discussed.
Same on line 574.

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

Add a blank line after declaration.

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

Can these be done without loop (just fix the size to cover both columns of the array)?

LEAHI-APPLICATION-LDT-1596-1 13 Aug 2025

Did you check if this will not impact all the other use cases, since this is a very low-level component?

LEAHI-TD-FIRMWARE-LDT-1903-8 25 Feb 2026

I don't think we need a start state as this state is doing nothing. It is just transitioning to the next state. We can just directly start from the next state.

LEAHI-APPLICATION-LDT-1636-1 13 Aug 2025

Remove unneeded semicolons.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

Thanks.
Please do items 1 and 3 for the first two checks, too.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

File Renamed and logic updated.
RESOLVED.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

File Renamed and logic updated.
RESOLVED.

LEAHI-TD-FIRMWARE-LDT-1903-8 25 Feb 2026

I think we have to define macros for magic number.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

updated

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

I would say "TRUE if request is accepted, FALSE if rejected."

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025
LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

Should you continue if the roleNames are empty?

LEAHI-TD-FIRMWARE-LDT-1903-8 13 Feb 2026

No, Yes for lowering event.

Fill event uses PWM 150 always irrespective of Qb and Venous pressure
only lower event used equation based PWM and that is in the range of 60-250 , not default., based on venous pressure it changes

RO-LDT-1809-3 13 Aug 2025

Resolved.

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

Add a variable to convert PWM count to target speed for monitor function.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

keeping PreTreatmentCreateContent.qml separate so I can later use that when populating the headerbar prescription Rx popup.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

updated and separated

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

updated and separated

LEAHI-TD-FIRMWARE-LDT-3259-1 27 Feb 2026

Is this necessary? If so, why?

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

added variables

LEAHI-TD-FIRMWARE-LDT-1903-8 26 Feb 2026

Why two leading zeroes?

LEAHI-TESTSUITES-LDT-2741-1 13 Feb 2026

translatable.
I won't repeat the same comment, but I see the same pattern elsewhere.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

revert to original

DG-DEN-14497-1 11 Jan 2023

Done

HD-DEN-14497-12 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DIAL-281-1 29 Aug 2023

Please add _MS to be consistent with the reset of times which are all in milliseconds.

DIALIN-DEN-14497-1 11 Jan 2023

RESOLVED.

DIALIN-DEN-14497-1 11 Jan 2023

why dict() is used instead of simply use {}?

RO-LEAH-1972-1 22 Jan 2025

Fixed.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Remove.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

File is reverse_osmosis.py. I actually don't like the file name. Prefer something like filtration_purification.py. Still ok with RO for folders and class names I think - though Jenna uses IOFP.

RO-LDT-566-1 27 Jun 2025

Remove blank line.

RO-LDT-566-1 27 Jun 2025

Remove extra blank line.

RO-LDT-566-1 27 Jun 2025

Remove extra blank line.