Already TRUE - why set again? I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).
it is being used and tend to be the bool. being alias of what? it is being used to let the dialog know if the dialog can be closed upon button press or just emit the signal.
Advantu team was assumed that false meant the proxy command was not accepted.
When we proxy messages through dialin using the dialin channels, the receiver ( HD or DG ) will ACK back in the non-proxied channel. Dialin will only considers received messages over its own set of CAN channels and will timeout due the ACK from the receiver being sent on the non-dialin channel
EX: Dialin will send Pressure limits change request over 0x400 HD accepts the message and will ACK back over 0x010 HD sends Pressure limits change response over 0x010 ( Dialin is monitoring via callback )
Proxy commands should be changed eventually... depends on how the users are applying them ( if they are expecting and using a return value like an override ). Older iterations of proxy commands do not return anything nor expect a Denali protocol ACK
Since these temperatures will be broadcast by the Temperatures monitor f/w unit and captured by the temperatures RO Dialin class, I think this override command should also be moved to the temperatures class.
Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories