•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14706-2 31 Aug 2023

Already TRUE - why set again?
I think "if" should be reversed - if not override, set used to FALSE. And then after if, always set result to TRUE (means we found a match - which we did).

UI-DEN-16288-1 30 Aug 2023

it is being used and tend to be the bool.
being alias of what?
it is being used to let the dialog know if the dialog can be closed upon button press or just emit the signal.

DG-DEN-16309-1 31 Aug 2023

Why 0.0F? memset() doesn't care about type - it just sets a number of bytes to given value.

UI-DEN-16288-1 30 Aug 2023

typo

UI-DEN-17157-2 24 Jan 2025

Done

DIALIN-DEN-16242-1 01 Sep 2023

Advantu team was assumed that false meant the proxy command was not accepted.

When we proxy messages through dialin using the dialin channels, the receiver ( HD or DG ) will ACK back in the non-proxied channel. Dialin will only considers received messages over its own set of CAN channels and will timeout due the ACK from the receiver being sent on the non-dialin channel

EX:
Dialin will send Pressure limits change request over 0x400
HD accepts the message and will ACK back over 0x010
HD sends Pressure limits change response over 0x010 ( Dialin is monitoring via callback )

Proxy commands should be changed eventually... depends on how the users are applying them ( if they are expecting and using a return value like an override ). Older iterations of proxy commands do not return anything nor expect a Denali protocol ACK

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Since these temperatures will be broadcast by the Temperatures monitor f/w unit and captured by the temperatures RO Dialin class, I think this override command should also be moved to the temperatures class.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "... the RO conductivity ..." here for specificity.

DG-DEN-14706-2 31 Aug 2023

Fixed. Thanks!

DG-DEN-14706-2 31 Aug 2023

Pushed wip code. I'm unsure what or if we need to put anything to compare override values.

DG-DEN-14706-2 01 Sep 2023

RESOLVED in CODE WALKTHROUGH.

RO-LDT-566-1 27 Jun 2025

Blank line between functions.

UI-DEN-16288-1 31 Aug 2023

RESOLVED

UI-DEN-16288-1 30 Aug 2023

This property is not being used.

Also, you might be able to alias the property that the Dialog (root component of ModalDialog).

LEAHI-APPLICATION-LDT-853-1 26 Jun 2025

Use the basic row, column layout instead.

RO-LDT-566-1 27 Jun 2025

Blank line between includes and group.

HD-DEN-14706-2 01 Sep 2023

RESOLVED in CODE WALKTHROUGH.

HD-STT-2824-1 01 Sep 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14706-2 31 Aug 2023

This if doesn't appear to be doing anything. Remove.

DG-DEN-14706-2 31 Aug 2023

This should be inverse of what you had before. I think this is too brief.

DG-DEN-14706-2 01 Sep 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

revert this too

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

Change to match other beginning { style.

UI-DEN-16335-1 05 Sep 2023

I remember and and can we use reconnect as a Paired State.

DG-DEN-14706-2 01 Sep 2023

Is the "0" an ACK,NACK, PENDING_OVERRIDE or some other flag? Suggest a #define. (or a comment)

DIALIN-DEN-16242-1 05 Sep 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-16288-1 30 Aug 2023

typo

UI-DEN-16335-1 05 Sep 2023

where do you use this ctor?

UI-DEN-16335-1 05 Sep 2023

not clear what it means.

UI-DEN-16335-4 06 Sep 2023

Perfect!
Thanks for giving it a try.

RESOLVED

UI-DEN-16335-1 05 Sep 2023

Yes, ticket wants pairing, but you had stated in a call that we need to go by the SRS or the requirement and the requirement attached to the ticket said disconnection/connection of accessories

UI-DEN-16335-1 05 Sep 2023

Per our call, you have agreed to leave it above in this location. No change in location

UI-DEN-16335-1 05 Sep 2023

please use the shorter constructor provided.
the error needs to be initialized as well, then it becomes the simple one.

UI-DEN-16335-1 05 Sep 2023

RESOLVED

HD-DEN-15972-1 05 Sep 2023

Update header

UI-DEN-16335-5 06 Sep 2023

Update the cpp as well

UI-DEN-16335-5 06 Sep 2023

I think we should use mL/min as is. and do not convert to Liter.

UI-DEN-16335-5 07 Sep 2023

Done.

DG-DEN-15973-1 30 Aug 2023

Please remove the blank line.

UI-DEN-16335-5 07 Sep 2023

Added.

UI-DEN-16335-5 07 Sep 2023

There is no CPP for this file. Unless you meant a different location

DG-DEN-14497-1 11 Jan 2023

RESOLVED IN CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

use Variable for dashes

DIALIN-DEN-14497-1 11 Jan 2023

RESOLVED.

UI-DEN-16288-1 30 Aug 2023

It currently has.

DG-DEN-16309-1 31 Aug 2023

Done.

LEAHI-APPLICATION-LDT-2160-1 12 Sep 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

done

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should be "Constructs and sends an RO flow sensor broadcast interval override command message."

DG-DEN-14706-2 31 Aug 2023

Fixed. Thanks!