•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2198-1 12 Sep 2025

Fixed.

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

done.

LEAHI-APPLICATION-LDT-853-1 26 Jun 2025

Replace with the basic row and column.

LEAHI-APPLICATION-LDT-2160-1 12 Sep 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-2198-1 15 Sep 2025

fixed. thanks

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Rename these per f/w refactoring changes.

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Rename these per f/w refactoring changes.

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Try to remove references to spelled out "reverse osmosis" like this (throughout all RO classes).
I would rephrase this as "Dialin API sub-class for RO conductivity sensor data access and override commands."

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "... published RO conductity ..." here for specificity.

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

DG should be RO.

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Rename these per f/w refactoring changes.

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Rename these per f/w refactoring changes.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

"Tx Code: "

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

moved .. maybe a rename too??

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

notify user its a duplicate and do not close popup

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Move the maximum, minimum, and resolution values for both potassium and calcium, as well as the comments in Variables.qml for now, but leave the //TODO comments here.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

reverted and kept the stack

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

The basic types like bool, int, ... do not need to be const &, and this improvement mainly affects classes.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

Please ensure that all ConnectWifi and DisconnectWifi (enum, function, class, function, error string, macro usage, etc.) functions use the 'wifi' as a prefix, like the others, to maintain consistency.
Like:
...WifiList...
...WifiInfo...
...WifiConnect...
...WifiDisconnect...

Please,

  • If it starts with wifi, then use non-capital 'w', like properties.
  • If in the middle, then use capital 'W'


This change needs to be done in the entire Device module (MVC,qml)
.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

As we talked, there is only one screen for this state "for now".
Since this aligns with the TD Op_Mode states, I believe it is more consistent and future-proof to keep the stack, although it is only one screen, "for now".
So, please revert the stack and remove the unused screen, leaving the PreTreatmentCreate.qml.
This way, if we need any additional screens later, we have the foundation in place.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

Should you continue if the value is empty?

I recommend being consistent and more flexible:
1 - to move the

QVariantMap map;

to the top of the function.
2 - add the lOut just before the

lOut:
    return map;

3 - on each check fail:

goto lOut;
LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

you have been removed

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

Remove extra blank line.

RO-LDT-1809-3 14 Aug 2025

Resolved

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

removed and added comment. Updated behavior to match as before. Thanks for catching that i didnt notice this once was a bit different

LEAHI-TD-FIRMWARE-LDT-2749-1 12 Feb 2026

This doesn't look right. Status = time?

LEAHI-TESTSUITES-LDT-3014-1 06 Feb 2026

these look like duplicates of already existing object.

This CR is for End of treatment and shouldnt have any pre treatment names under this section

LEAHI-DD-FIRMWARE-LDT-3344-1 12 Feb 2026

add new valves.

LEAHI-TD-FIRMWARE-LDT-1903-8 25 Feb 2026

I don't see it being used in this state. Do we need this?

LEAHI-TD-FIRMWARE-LDT-1903-8 25 Feb 2026

This is a default framework for all modules, even though there is nothing right now, left it as it is.

LEAHI-TD-FIRMWARE-LDT-3126-1 26 Feb 2026

Let's go ahead and do this.

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

need documentation for this two approach, what is the merits ? when to use it ?

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

DG-DIAL-281-1 29 Aug 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-14497-1 11 Jan 2023

I think we decided to define the return type for at least functions that have return values other than None.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-1972-1 22 Jan 2025

Done.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Remove chem disinfect. Leahi not currently slated to have a chem disinfect.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-2160-1 12 Sep 2025

RESOLVED

DG-DEN-14497-1 11 Jan 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-DD-FIRMWARE-LDT-2030-2 12 Feb 2026

done.