•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Handles published RO pump data messages (not blood).

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "override RO conductivity ..." here for specificity.

LEAHI-DIALIN-LEAH-136-3 22 Jan 2025

Rename these per f/w refactoring changes.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should be "...sends an RO valve data broadcast interval override command message."

RO-LDT-566-1 25 Jun 2025

fixed

TD-LDT-1886-7 29 Sep 2025

Not needed.

RO-LDT-566-1 25 Jun 2025

fixed

RO-LDT-566-1 25 Jun 2025

Remove extra blank line.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

1) remove the doInintWifiList
2) call the wifiInforequest
3) add a function to highlight the active connection(empty or not)
4) The function in step 3 needs to be called in the call of step 2.

LEAHI-TESTSUITES-LDT-2085-1 24 Sep 2025

We should remove the "Text" key from all these containers as they may change over time.

LEAHI-APPLICATION-LDT-1440-1 25 Sep 2025

Verify colors versus denali.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

removed

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-APPLICATION-LDT-853-1 26 Jun 2025

For the main treatment story, just focus on the screen content itself, and please remove any placeholder in this file.

LEAHI-APPLICATION-LDT-853-1 26 Jun 2025

make this a separate very simple component,
use constant W,H

LEAHI-APPLICATION-LDT-2666-1 27 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-1021-1 26 Jun 2025
  • If I remember correctly, we decided to assign the rest of the string to the DNS and manipulate it in the QML.
  • Generally, always use i++ in all for loops to maintain consistency.
  • Please consider using the mid function from the QStringList, which uses \n as a delimiter. Additionally, we can avoid using the "," since we are breaking into lines.

dns = fields.mid(eDNS).trimmed();

Please verify the proposed code for correctness.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

Thanks
RESOLVED.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

File Renamed and logic updated.
RESOLVED.

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

File Renamed and logic updated.
RESOLVED.

DD-LDT-1873-1 13 Aug 2025

Done.

LEAHI-APPLICATION-LDT-1656-1 13 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 13 Aug 2025

Declare variables using 'auto' and 'const auto' where possible, especially where initializing the variable.

LEAHI-APPLICATION-LDT-1596-1 13 Aug 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1596-1 13 Aug 2025

Did you check if this will not impact all the other use cases, since this is a very low-level component?

LEAHI-APPLICATION-LDT-1636-1 14 Aug 2025

Make each of these, as properties with constant values.

  • _rightColumnWidth
  • _leftColumnWidth
  • _columnSpacing
LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

fix this it shouldnt

left : parent.left

DG-DEN-14497-1 11 Jan 2023

Done

DG-DEN-14497-1 10 Jan 2023

Keep blank line between declarations and code.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Is FP version meaningful? I think we will only have a DD f/w version and a DD FPGA version.

HD-DEN-15980-1 23 Aug 2023

Updated spelling and as Input here.

HD-DEN-15980-1 24 Aug 2023

Fix comment alignment.

RO-LEAH-1972-1 22 Jan 2025

Pressure sensor temps to stay with pressure as these temps do not have their own component designator on the flow path.

HD-STT-1965-1 25 Aug 2023

Corrected

DG-DEN-15973-1 25 Aug 2023

Corrected

LEAHI-DIALIN-LEAH-136-2 22 Jan 2025

Remove.

DG-DEN-16093-1 28 Aug 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

add ()

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

Please remove this gradient.

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

keep this and push
page( _pretreatmentCreate )}

UI-DEN-16288-1 28 Aug 2023

if statement indentation

RO-LDT-566-1 30 Jun 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-2160-1 05 Sep 2025

add ()

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Should say "... the RO conductivity ..." here for specificity.

LEAHI-DIALIN-LEAH-136-3 23 Jan 2025

Not blood flow.

UI-DEN-17157-2 23 Jan 2025

add "-L" and the "&"as we talked.