•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-16288-1 30 Aug 2023

It currently has.

DG-DEN-16309-1 31 Aug 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-16288-1 31 Aug 2023

removed

DD-LEAH-1971-1 27 Jan 2025

Mention "ramp" somewhere in name or at least comment.

UI-DEN-16288-1 31 Aug 2023

RESOLVED

UI-DEN-16288-1 31 Aug 2023

RESOLVED

UI-DEN-16335-5 06 Sep 2023

param 11 is missing

01    F32-refUFVolMl	              
02    F32-measUFVolMl	              
03    F32-measRotSpdRPM	            
04    F32-measSpdRPM	              
05    F32-measMCSpdRPM	            
06    F32-measMCCurrmA	            
07    F32-setPWMpct	                
08    F32-dopCorrOffset	            
09    F32-dopCalcRate	              
10    F32-ufCalcRate	              
11    U32-rotorHall	                
12    F32-currentSetUFRate          

HD-STT-2824-1 31 Aug 2023

Extra blank lines?

DG-DEN-14706-2 01 Sep 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14706-2 31 Aug 2023

See my comment in DG branch - same issue.

HD-DEN-14706-2 31 Aug 2023

Too many () after &&.

DD-LEAH-1971-1 27 Jan 2025

Remove extra blank line.

HD-DEN-14706-2 01 Sep 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-16335-5 06 Sep 2023

param 11 is missing

01    F32-refUFVolMl	              
02    F32-measUFVolMl	              
03    F32-measRotSpdRPM	            
04    F32-measSpdRPM	              
05    F32-measMCSpdRPM	            
06    F32-measMCCurrmA	            
07    F32-setPWMpct	                
08    F32-dopCorrOffset	            
09    F32-dopCalcRate	              
10    F32-ufCalcRate	              
11    U32-rotorHall	                
12    F32-currentSetUFRate          
UI-DEN-16335-1 05 Sep 2023

This is no longer applicable due to the changes from our conversation.

DD-LEAH-1971-1 27 Jan 2025

Should this be at the very top of this header file?

UI-DEN-16335-1 05 Sep 2023

We clarify this thread with a call.

UI-DEN-16335-1 05 Sep 2023

RESOLVED

UI-DEN-16335-1 05 Sep 2023

when do we know if that is paired, I think the ticket wants that one, right?

UI-DEN-16335-1 05 Sep 2023

make them one-liner in front of the if/else and align.

UI-DEN-16335-4 06 Sep 2023

We want the directories itself to be set as "readable" to have ls, and the files not readable to avoid cat/opening

Out of curiosity, I tried it. It only set the files in the subfolder in CloudSync to have those permissions. The files in the parent directory is not changed.

DD-LEAH-1971-1 28 Jan 2025

Done.

DG-DEN-16314-1 07 Sep 2023

Done. Code updates pushed.

DD-LEAH-1971-1 28 Jan 2025

Done.

DG-DEN-16314-1 07 Sep 2023

I don't see these being used anywhere.

DD-LEAH-1971-1 28 Jan 2025

Reserved.

UI-DEN-16335-5 11 Sep 2023

Resolved and tested.

DD-LEAH-1971-1 28 Jan 2025

Done.

DD-LEAH-1971-1 27 Jan 2025

I believe this increment is for ramping. Would be helpful to have the word "ramp" somewhere in the name or at least in the comment.

Also, indent on comment is out of alignment.

DG-DEN-16314-1 08 Sep 2023

These fields have been moved to a different broadcast at some point, and were no longer being set by the reservoir data broadcast. The fields regularly contained "NAN" values, so I removed them.

HD-DEN-15792-1 07 Sep 2023

Align declaration comments as a block on the right.

HD-DEN-15792-1 08 Sep 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-16314-1 08 Sep 2023

Why are these fields removed?

DD-LEAH-1971-1 28 Jan 2025

There is no standby solo mode in Leahi. I think we would trigger a recoverable comm loss alarm.

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

UI-DEN-16335-5 11 Sep 2023

RESOLVED

UI-DEN-16288-1 11 Sep 2023

fixed.

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

UI-DEN-16288-1 11 Sep 2023

RESOLVED

LEAHI-DIALIN-LEAH-139-3 29 Jan 2025

".. concentrate pump parked status ..".

UI-DEN-16288-1 11 Sep 2023

Since Vy is busy and it is not a code change and is only type
I do resolve on her behalf.
RESOLVED

UI-DEN-16288-3 11 Sep 2023

fixed

UI-DEN-16288-3 11 Sep 2023

since Vy is busy and the comment is a typo, I resolve on her behalf.
RESOLVED

UI-DEN-16335-7 11 Sep 2023

RESOLVED

UI-DEN-16335-3 11 Sep 2023

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

UI-DEN-16335-1 11 Sep 2023

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

UI-DEN-16335-1 11 Sep 2023

RESOLVED

UI-DEN-16335-5 11 Sep 2023

I made myself the moderator to close the review after I was done with my 100% no comment left completed review.

DIALIN-DEN-14497-1 11 Jan 2023

Done where?