Should 524 be removed?
needs assignment alignment.
RESOLVED in CODE WALKTHROUGH.
Remove extra blank line.
Why is driving this change? And should other proxy commands be changed as well?
RESOLVED
Done.
typo "faillure"
RESOLVED in CODE WALTHROUGH
This is the minimum values that are needed to clear the alarm.
Yes these are for software configuration disable only so I did not make any #defines for them.
You at least need to add a comment explaining what they are.
RESOLVED IN CODE WALKTHROUGH
Should be DD.
This request is to switch balancing chamber without pressure/dosing/heater/pumping functionality. the use case for now is to do manual priming process. Will reevaluate further as we develop more use cases.
Done
Removed.
This function is pretty large. Recommend moving some of this code to smaller static functions and calling them from the monitor function.
Align "=" signs.
Are we done with the 250 version of control interval? Can we remove?
You won't need a switch if you use an array per previous comment.
Should be 3251_9
thanks, fixed!
After a quick discussion, let's keep the message ID enum in the common dialin as 'bloodPump', but everywhere else, please change it to 'bloodflow'.
fixed. thanks!
Align all comments in same column.
align the =
According to this comment this need to be H6. http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-627-1CFR-67994
RESOLVED as we discussed.
Please refactor the names to match the application's message naming for clarity.
fixed!
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
