RESOLVED
Radu: "Fixed"
RESOLVED It has been addressed mostly and has some extra comments about that.
RESOLVED. It has been addressed in other comments.
Alignment
RESOLVED.
Why remove initial value for alarmIndex?
Comment is 12bit specific, but code updated to use different references per thermistor.
Comment does not explain what the numbers are - 3, 10, 10.
No initial value for alarmID. Can it end up not set before use in checkPersistentAlarm?
This class now has a header/brief, but other classes do not appear to have been updated.
fixed. thanks!
her. => here.
Remove extra blank line.
These to values appear to be minimums. Why are they being called maximums?
Done.
Missing new targetVolume_ml param in header.
Why 1 and 0? Do these make sense?
Should this be at the top? Any reason to include a bunch of header files if there's no code below?
Comment seems unnecessary.
Dara suggested removing this, as the feature was incomplete and appears to cause odd timer/alarm behavior.
You are removing recover treatment test config functionality? Is this moving somewhere else or we've decided not to implement?
Done
RESOLVED in CODE WALKTHROUGH.
Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.
Why are we doing this here? And why repeatedly every 500ms? Why not just once after NV POST state?
"override concentrate pump target speed:"
"..measured concentrate pump speed: "
align with the rest
For B1.0/B1.9 - Where Diener silencer 2000 pumps, this macro needs to be enabled.
I utilize the sliders and auto change of any of the components so send and reset buttons are not needed. I can demo
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
