•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-16442-1 19 Sep 2023

Done

HD-DEN-16442-1 19 Sep 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16442-1 19 Sep 2023

Should we have a local var for active reservoir too?

HD-DEN-14549-1 17 Jan 2023

Done.

HD-DEN-14549-1 17 Jan 2023

Done.

HD-DEN-16442-1 20 Sep 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14549-1 17 Jan 2023

Done.

DG-DEN-13946-1 17 Jan 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13946-1 17 Jan 2023

RESOLVED IN CODE WALKTHROUGH

UI-DEN-16419-3 26 Sep 2023

this branch rename due to conflict and confusion.
code review will be followed up in the following CR:
http://devapps.diality.us:8060/cru/UI-DEN-16419-5
this cr will be closed.

DG-DEN-14559-1 17 Jan 2023

Rename to isDGFaultActive.

HD-DEN-14549-1 17 Jan 2023

They're kind of different. The stop function is fairly straightforward and is part of syringe pump driver. The start function is a lot more complex as it needs to figure out what it should be doing and is part of treatment mode module.

DG-DEN-14559-1 17 Jan 2023

This alarm does not appear to be available. Correct description in last column (trigger condition).

HD-STT-3088-1 26 Sep 2023

Enclose each boolean statement in separate parenthesis.

DIALIN-DEN-16428-1 24 Sep 2023

Remove extra "to".

DG-DEN-14559-1 17 Jan 2023

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

DG-DEN-14559-1 17 Jan 2023

Variable should already be a BOOL.

DG-DEN-14559-1 17 Jan 2023

Set to TRUE here.

DG-DEN-14559-1 17 Jan 2023

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

DG-DEN-13676-1 17 Jan 2023

Removed

HD-DEN-14549-1 17 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14549-1 17 Jan 2023

Add pressureSelfTestPreNormalStartTime to header.

HD-DEN-14549-1 17 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14549-1 17 Jan 2023

Add pressureSelfTestPreNormalStartTime to header.

HD-DEN-14549-1 17 Jan 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14549-1 17 Jan 2023

Add pressureSelfTestNormalizedStartTime to header.

DG-DEN-13946-1 17 Jan 2023

RESOLVED IN CODE WALKTHROUGH

CS-BUILD-0-2-4-1 17 Jan 2023

RESOLVED.

CS-BUILD-0-2-4-1 17 Jan 2023

RESOLVED.

CS-BUILD-0-2-4-1 17 Jan 2023

RESOLVED.

DG-DEN-13676-1 17 Jan 2023

Is this #define still used/needed?

DG-DEN-14559-1 17 Jan 2023

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

DG-DEN-14559-1 17 Jan 2023

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

DG-DEN-14559-1 17 Jan 2023

Initialize to FALSE.

DG-DEN-14559-1 17 Jan 2023

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

DG-DEN-14559-1 17 Jan 2023

Seems like there are several variables missing.

HD-DEN-14561-1 17 Jan 2023

This config check is unnecessary and should be removed. The vars should always be initialized. Enable/Disable Alarms are done when checking the direction, etc.

CS-BUILD-0-2-4-1 17 Jan 2023

RESOLVED.

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

DG-DEN-15973-2 14 Sep 2023

Align comment.

DG-DEN-15973-2 14 Sep 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-1971-1 28 Jan 2025

Should TD# be changed to new component code?

DD-LEAH-1971-1 28 Jan 2025

Does floater 2 have a component code?

DIALIN-DEN-16419-1 14 Sep 2023

Fixed

HD-DEN-16442-1 18 Sep 2023

Done

LEAHI-DD-FIRMWARE-LDT-2198-1 16 Sep 2025

Is it FP software fault, instead of TD fault?

HD-DEN-16442-1 19 Sep 2023

Done

HD-DEN-16442-1 19 Sep 2023

Should this be active reservoir?

DD-LEAH-1971-1 29 Jan 2025

Done.

HD-DEN-16442-1 19 Sep 2023

Just these 2 alarms? Should we check for any alarm that STOPS treatment?