•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14559-1 19 Jan 2023

Done

DG-DEN-14559-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14328-1 19 Jan 2023

Fixed. Thanks!

HD-DEN-14328-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-TD-FIRMWARE-LDT-1903-8 26 Feb 2026

I am resolving it, but according to Sean, if we have a state which is just asking it to go to the next state, we might not need the state to be declared.

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

DG-DEN-15973-2 14 Sep 2023

Done

DD-LEAH-1971-1 28 Jan 2025

Done.

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

HD-DEN-16442-1 18 Sep 2023

I think we have to remember last fill volume for each reservoir and refer to that.
With this approach, if user changes Qd, the percentage will be wrong.

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-14328-1 19 Jan 2023

Fixed. Thanks!

DD-LEAH-1971-1 28 Jan 2025

Done.

HD-DEN-14328-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-1971-1 27 Jan 2025

Shouldn't we assign the minimum here (maybe that is 0.0, but we should use the #define).

DD-LEAH-1971-1 27 Jan 2025

Let's be consistent on how we handle multiple heaters. Here it's if/else but in other places it's a switch.

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

HD-DENBUG-290-1 29 Jan 2025

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16442-1 19 Sep 2023

RESOLVED IN CODE WALKTHROUGH.

DD-LEAH-224-1 24 Feb 2025

Remove these blank lines.

HD-DEN-16442-1 20 Sep 2023

Done

HD-DEN-16457-1 27 Sep 2023

Alignment updated.

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

method has been removed. Thanks!

LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

DG-DEN-16446-1 28 Sep 2023

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

LEAHI-DIALIN-LEAH-136-3 06 Feb 2025

my bad. Now its fixed!

UI-DEN-17157-1 25 Feb 2025

RESOLVED

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

The naming has the new codes now, but still does not match the f/w. Firmware has _VALV suffix, not old code.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

I do not see fix.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

levels_sync?

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DD. replace DG to DD across file.

UI-DEN-17157-2 14 Feb 2025

Done

TD-LEAH-838-1 21 Feb 2025

Done.

TD-LEAH-838-1 21 Feb 2025

Fixed.

DD-LEAH-224-1 24 Feb 2025

Done.

DD-LEAH-224-1 24 Feb 2025

Done.

DD-LEAH-224-1 24 Feb 2025

Recommend removing this.

UI-DEN-17157-2 25 Feb 2025

RESOLVED

UI-DEN-17157-1 25 Feb 2025

please align the " ,2"

UI-DEN-17157-1 25 Feb 2025

please do the same as the comment in the following link:
http://devapps.diality.us:8060/cru/UI-DEN-17157-1#c21568

DG-DEN-17234-1 27 Feb 2025

Are these permanent changes?

UI-DEN-17157-1 25 Feb 2025

RESOLVED

It is fine for now that the following not fixed:
1 - the

Variables.notSetVariable(vTreatmentVitals.systolic,  2)

is not used here.
2 - the properties still have dryDemo as prefix.

RO-LEAH-273-1 05 Mar 2025

added column. Thanks!

RO-LEAH-273-1 04 Mar 2025

Should also verify we are even in standby mode before accepting this request.

DD-LEAH-230-1 27 Feb 2025

Make literals floats explicitly (i.e. 800.0F / 1000.0F).

LEAHI-APPLICATION-LDT-1021-1 29 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-1021-1 29 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align