•  

Comment Results

Review Name Created Custom Fields Content
HD-DENBUG-96-1 11 Oct 2023

Fixed.

HD-DENBUG-96-1 11 Oct 2023

Add setUFRate to header

HD-DEN-14561-1 19 Jan 2023

This looks like we're skipping draining of reservoirs before doing any filling if priming disabled. I think we always want to drain both reservoirs first.
Also, if we go to fill state like this, will it do a flush or a normal fill? I think it will do a flush fill since flushed flag is still FALSE.

HD-DEN-11098-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-13834-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-13598-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-13598-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-12974-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-9906-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-11928-1 18 Mar 2022

Renamed setBottlesNeedPrimeFlag() to setThisFirstFillFlag()

DG-DEN-11928-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-11928-1 18 Mar 2022

This get function is never called outside of fill mode - should be private (static) inside .c file.

DG-DEN-11750-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-11750-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-9480-1 04 Nov 2021

Handling of passive notification is removed in my branch.

DG-DEN-9480-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-7568-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-7395-1 08 Apr 2021

Usually the self tests return SELF_TEST_STATUS_T. Why does this function return a BOOL instead?

HD-DEN-7395-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-6402-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-5674-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-4308-3 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-2379-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-13903-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-1312-1 09 Jan 2020

Is this commBuffers not called from different threads? if so, don't we need it to set it to volatile too?

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

UI-DEN-15896-1 19 Oct 2023

RESOLVED

UI-DEN-15279-1 19 Oct 2023

RESOLVED

CS-BUILD-0-2-4-1 19 Oct 2023

RESOLVED

UI-DEN-3149-1 19 Oct 2023

RESOLVED

DIALIN-DEN-14497-1 19 Oct 2023

RESOLVED

UI-DEN-3605-4 28 Aug 2020

Remove extra line.

DIALIN-DEN-14497-1 19 Oct 2023

RESOLVED

DIALIN-DEN-2652-1 19 Oct 2023

RESOLVED

DIALIN-DEN-1404-1 16 Jan 2020

So I've been piling up sub-classes in this one big HD class. Here you are importing yours from an outside .py file. We should be consistent. Are you proposing we separate all of the sub-classes into separate classes with their own .py file?

HD-DEN-16446-2 13 Oct 2023

Check casting. Result is U32 but could be assigned an S32.

HD-DEN-14328-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16446-1 01 Oct 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16475-1 09 Oct 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-16454-1 19 Oct 2023

Resolved.

DD-LEAH-1971-1 28 Jan 2025

Done.

DD-LEAH-1971-1 28 Jan 2025

Done.

DG-DEN-16446-2 17 Oct 2023

The "2" is common shorthand for "TO". Ok to keep as is I think.

DIALIN-DIAL-289-1 17 Oct 2023

Fixed. Thanks!

DG-DEN-13598-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-12974-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11250-1 15 Feb 2022

Why are these here in Common.h? Move to sys_selftest.c in user defined section.

HD-DEN-431-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH