Comment Search

Defect Metrics

Statistics on the results
No defects in results

Search Criteria

Search for comments

Search Criteria

Project
Comment content
Review PermaId
After
Before
Comment Author
Search Type
Search Type:
Review State
Review State:
Metrics:
Metric Ranking
Metric Classification
Submit
  •  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14549-1 23 Jan 2023

RESOLVED IN CODE WALKTHROUGH
HD-DEN-14549-1 22 Jan 2023

Need to verify SRS and AlarmsDef.h are in sync.
HD-DEN-14561-1 20 Jan 2023

Done.
HD-DEN-14561-1 20 Jan 2023

Done.
HD-DEN-14549-1 22 Jan 2023

Alignment
HD-DEN-14549-1 25 Jan 2023

Need to verify all alarms with SRS.
HD-DEN-14549-1 25 Jan 2023

Alignment
HD-DEN-14561-1 25 Jan 2023

RESOLVED IN CODE WALKTHROUGH
HD-DEN-14561-1 20 Jan 2023

Should align
HD-DEN-14561-1 25 Jan 2023

RESOLVED IN CODEWALKTHROUGH
HD-DEN-14549-1 20 Jan 2023

Extra white space.
DG-DEN-14604-1 24 Jan 2023

Comments
DG-DEN-14604-1 02 Feb 2023

Temporary?
DG-DEN-14589-1 01 Feb 2023

Alphabetical ordering.
HD-DEN-14549-1 27 Jan 2023

Done.
HD-DEN-14549-1 27 Jan 2023

Done.
HD-DEN-14549-1 27 Jan 2023

Not required.
HD-DEN-16446-1 03 Oct 2023

Are these F32s?
HD-DEN-14549-1 27 Jan 2023

Will have you do that when I can merge this branch.
DG-DEN-16372-1 04 Oct 2023

Fixed.
HD-DEN-14549-1 27 Jan 2023

Not required.
HD-DEN-14549-1 27 Jan 2023

Fixed.
DG-DEN-16446-1 02 Oct 2023

Should this have a set of parenthesis around the condition similar to line 437?
HD-DEN-14549-1 27 Jan 2023

Fixed.
HD-DEN-14549-1 30 Jan 2023

RESOLVED IN CODE WALKTHROUGH
HD-DEN-14344-3 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH
DG-DEN-14316-1 21 Nov 2022

Alignment.
DIALIN-DEN-14589-1 30 Jan 2023

I had added button and safety line in another branch. Why removing?
DIALIN-DEN-14589-1 30 Jan 2023

What happened to reservoir inlet valve?
HD-DEN-13834-1 19 Sep 2022

Should struct members be aligned?
DIALIN-DEN-14589-1 30 Jan 2023

They are currently out of sync with latest staging builds. Kendrick is currently failing his testing using staging builds if he uses enum 18 to get the HD_EVENT_SUB_STATE_CHANGE that was done in http://devapps.diality.us:8060/cru/HD-DEN-14328-1#details

How do you wish to resolve this?
DG-DEN-13460-2 29 Aug 2022

Are we moving away from initializing via definition?
HD-DEN-14561-1 20 Jan 2023

Done, initial drain of the reservoirs, prior to syncing with the self-test.
HD-DEN-14549-1 26 Jan 2023

Add spaces around < ?
HD-DEN-9906-1 26 Oct 2021

add last else
else
{

}
HD-DEN-9906-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH
DG-DEN-6200-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH
DG-DEN-2379-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH
DG-DEN-14604-1 02 Feb 2023

Not fault mode?
DG-DEN-14604-1 03 Feb 2023

Removed the code.
DG-DEN-14589-1 02 Feb 2023

Just include HDCommon.h and it will include things like this.
DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-14561-1 02 Feb 2023

Done.
HD-DEN-14561-1 02 Feb 2023

Done.
HD-DEN-14561-1 02 Feb 2023

Do we understand why this is needed?
HD-DEN-14561-1 02 Feb 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-14561-1 02 Feb 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-14561-1 02 Feb 2023

RESOLVED in CODE WALKTHROUGH.
HD-DEN-14561-1 31 Jan 2023

Alignment of comment.
HD-DEN-14561-1 02 Feb 2023

RESOLVED in CODE WALKTHROUGH.