Comment Search

Seems like this flush tracking logic should be done in fill complete state (after fill, not before).

RESOLVED in CODE WALKTHROUGH.

Removed the code.

Let's keep this broadcast until this project is finished.

I think #defines are still appropriate. Since it's debug code, they can be placed right above the function (inside the #ifndef RELEASE) so they do not get used in release s/w.

RESOLVED in CODE WALKTHROUGH.

For a blank case like this, we should add a comment making it clear no action is intended.

Removed the code.

No this has been removed.

Even in release build?

Is this necessary? We're faulting. Won't be coming back. Even if we did come back, wouldn't init set this?

Is this temporary? Should it have #ifndef RELEASE?

Will do a bulk catch-up on this later when we have some time. For now, it is functional and will have to do.

This is currently in sync with the VALVES_T struct in the DG firmware.

/// Enumeration of valves.
typedef enum Valves

VRF = 0, ///< Valve Reservoir Fill
VRI, ///< Valve Reservoir Inlet
RSRVD_SPACE, ///< This space has been reserved
VRO, ///< Valve Reservoir Outlet
VPO, ///< Valve Pressure Outlet
VBF, ///< Valve Bypass Filter
VRC, ///< Valve Recirculate
VDR, ///< Valve Drain
VPI, ///< Valve Pressure Inlet
VSP, ///< Valve Sampling Port
VRD1, ///< Valve Reservoir 1 Drain
VRD2, ///< Valve Reservoir 2 Drain
VPD, ///< Valve Production Drain
NUM_OF_VALVES ///< Number of valves
VALVES_T;


Dara Navaei may be able to clarify as to why

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Ok, not sure how this got into staging already. Will have to add it back later.
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Add blank line between declaration and code.

I don't see this being used anywhere. Remove.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Is this meant to be the 2nd gradient check. Maybe a clearer symbol name?

Fixed.

RESOLVED IN CODE WALKTHROUGH