•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13598-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-13460-2 29 Aug 2022

Some values have "U"?

HD-DEN-14273-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14316-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13460-2 29 Aug 2022

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

DG-DEN-11928-1 22 Mar 2022

Those #define below will not be removed until they are added into the calibration records.
#define ACID_NORMAL_CONDUCTIVITY 11645.05
#define BICARB_NORMAL_CONDUCTIVITY 13734.88

DG-DEN-11750-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-11750-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-6890-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-6402-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-6402-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-2379-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-3115-1 07 Jul 2020

Misspelled significant and this should be 3-byte word?

HD-DEN-15049-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-11750-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-13460-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

UI-DEN-15833-1 19 Oct 2023

RESOLVED

UI-DEN-15279-5 19 Oct 2023

RESOLVED

UI-DEN-15279-1 19 Oct 2023

RESOLVED

UI-DEN-15279-1 19 Oct 2023

RESOLVED

UI-DEN-15279-1 19 Oct 2023

RESOLVED

UI-DEN-608-4 04 Dec 2019

Verb

UI-DEN-608-4 19 Oct 2023

RESOLVED

UI-DEN-608-4 04 Dec 2019

Same comment as above. We need a clue what is happening. "Can Device is connected"

UI-DEN-608-4 04 Dec 2019

Please make status more verbose, e.g., "Can Device is now disconnected"

UI-DEN-608-4 19 Oct 2023

RESOLVED

UI-DEN-608-4 19 Oct 2023

RESOLVED

UI-DEN-704-1 05 Dec 2019

Add commented line with the name of the script. Don't we need headers for these scripts?

UI-DEN-15833-6 19 Oct 2023

RESOLVED

DIALIN-DEN-13427-1 19 Oct 2023

RESOLVED

DIALIN-DEN-13460-1 19 Oct 2023

RESOLVED

DIALIN-DEN-1404-1 19 Oct 2023

RESOLVED

DIALIN-1 19 Oct 2023

RESOLVED

HD-DEN-16446-2 16 Oct 2023

I think we need the minimum check too. uFRate can be negative if user sets volume to something lower than what has already been collected (negative volume) which would yield a negative rate which is < 0.0.

DIALIN-DEN-16454-1 19 Oct 2023

If the UI can ignore the fields, then why does dialin need to match the UI?

DG-DEN-14604-1 03 Feb 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16446-1 03 Oct 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14561-1 03 Feb 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14561-1 02 Feb 2023

This math no longer works because we changed the displacement time from 1 minute (which allowed for this simplified approach) to 30 seconds.
Generalize the math.

Suggested approach:
-integrate volume above properly (don't just sum rates over time).
-Should be: fmdIntegratedVolume += ( getMeasuredDialInFlowRate() / (F32)( ( SEC_PER_MIN * MS_PER_SECOND ) / TASK_GENERAL_INTERVAL ) );
-Then we don't need to convert here at end of displacement - can just use fmdIntegratedVolume as is in verify state.

DG-DEN-16395-1 04 Oct 2023

RESOLVED in CODE WALKTHROUGH

DIALIN-DEN-16428-1 04 Oct 2023

Fixed. Thanks!

HD-DENBUG-84-1 03 Oct 2023

We should not be doing a Heparin bolus in treatment mode. It should be completed in pre-treatment mode. transitionToDialysis() function will resume Heparin dispense (not bolus) if necessary when treatment is resumed.

DG-DEN-16446-1 09 Oct 2023

RESOLVED IN CODE WALKTHROUGH

UI-DEN-15279-1 19 Oct 2023

RESOLVED

DIALIN-DIAL-289-1 12 Oct 2023

Should be = END_POS_COMP now, right?

DIALIN-DIAL-289-1 17 Oct 2023

RESOLVED.

HD-DEN-15918-1 18 Oct 2023

RESOLVED in CODE WALKTHOURHG

DG-DEN-14859-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13834-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH