•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15363-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-14646-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13598-2 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

align ;}

DG-DEN-12931-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-11750-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-11750-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-4308-3 27 Aug 2020

Same comments as above re: absolute values.

DG-DEN-4217-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-4217-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-3421-1 13 Aug 2020

Missing one / for doxygen comment.

DG-COMMON-FIX-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-COMMON-FIX-1 27 Mar 2020

I really like the name "Solo".

HD-DEN-15436-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-13460-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-11750-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-1312-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-13460-2 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

HD-DEN-14150-1 19 Oct 2023

RESOLVED in CODE WALKTHROUGH

UI-DEN-15905-10 19 Oct 2023

RESOLVED

UI-DEN-15833-4 19 Oct 2023

RESOLVED

UI-DEN-15279-5 19 Oct 2023

RESOLVED

UI-DEN-608-4 04 Dec 2019

Method needs verb

UI-DEN-704-1 19 Oct 2023

RESOLVED

UI-DEN-15833-6 19 Oct 2023

RESOLVED

UI-DEN-3605-4 19 Oct 2023

RESOLVED

DIALIN-BUG-S63-1 19 Oct 2023

RESOLVED

DIALIN-DEN-4211-1 19 Oct 2023

RESOLVED

DIALIN-DEN-16454-1 19 Oct 2023

Please remove blank line.

UI-DEN-16490-1 11 Oct 2023

Did you mean to leave these commented out ?

DG-DEN-16446-1 28 Sep 2023

Done

HD-DENBUG-64-1 18 Oct 2023

RESOLVED in CODE WALKTHROUGH

DG-DEN-14859-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-16446-1 27 Sep 2023

What's left? When would this code ever become reachable?

HD-DEN-14561-1 19 Jan 2023

Old transfer was 600mL, new is 300mL. Res 1 should end up with 1500 so added 300 to baseline, Res 2 was previously ending with 500. Do we want it to end R2 with 300?

DG-DEN-16395-1 03 Oct 2023

Done.

DG-DEN-14604-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-16446-1 03 Oct 2023

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

DG-DEN-16395-1 03 Oct 2023

Please remove these cases.

DG-DEN-16475-1 09 Oct 2023

Add doxygen comment.

DG-DEN-16446-1 08 Oct 2023

sizeof should be first in if

HD-DEN-14328-1 19 Jan 2023

Fixed. Thanks!

HD-DEN-14328-1 19 Jan 2023

Fixed. Thanks!

HD-DEN-14328-1 19 Jan 2023

Add blank line between declaration and code.

HD-DEN-14328-1 19 Jan 2023

Put this (and blank line after) at top of function.

HD-DEN-14328-1 19 Jan 2023

Put this (and blank line after) at top of function.

HD-DEN-14328-1 19 Jan 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14328-1 19 Jan 2023

Add blank line between declaration and code.

HD-DEN-14561-1 19 Jan 2023

There are two dialysate prime states. First goes through dialyzer and both DPs are running and we still want 300 rate. Second bypasses dialyzer and only DPi is running and we want 600 rate.

DG-DEN-13834-1 18 Oct 2023

RESOLVED IN CODE WALKTHROUGH