No application repo changes was required for the dry-demo the changes ar made and review in the following. http://devapps.diality.us:8060/cru/UI-DEN-16419-5 this CR will be closed.
The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).
Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.
In some places in this unit, I see an if/else structure (if is acid and else assumes bicarb) which is cleaner - no need for default with alarm. I'm ok with either approach, but we should be consistent throughout the unit.
Please add a comment to ensure this is removed before merging to staging. You can keep this as the last comment to resolve if it is used for development testing.
