•  

Comment Results

Review Name Created Custom Fields Content
RO-LEAH-273-1 06 Mar 2025

Not necessary if you check for this in exec as I recommended in comment above.

RO-LEAH-273-1 06 Mar 2025

High state should be handled in above condition and removed here.

RO-LEAH-273-1 11 Mar 2025

Add blank line between break and default.

RO-LEAH-273-1 06 Mar 2025

Not initial state. Full state.
stateDelayTime is at least one input (not none).
Returning "next" state, not current state.

RO-LEAH-273-1 06 Mar 2025

Add spaces between () and params (throughout).

UI-LEAH-2077-2 18 Mar 2025

Those are structures and our agreement was to keep them hidden from SW since the FW has FW types for the struct elements that are not defined here and fail the build.
Additionally SW won't even use them.

TD-LEAH-60-1 17 Mar 2025

RESOLVED IN CODE WALKTHROUGH.

UI-LEAH-2077-2 18 Mar 2025

I prefer you change to just "UI" in enum names and comments to right.

HD-DENBUG-298-1 14 Mar 2025

Are we removing maximum saline bolus volume limit?

HD-DENBUG-298-1 18 Mar 2025

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1 18 Mar 2025

Done

HD-DENBUG-298-1 18 Mar 2025

RESOLVED in CODE WALKTHROUGH.

UI-LEAH-2077-2 18 Mar 2025

Lets pick an alignment approach and be consistent. Looks like you prefer aligning the "=" to far right. That's fine, but then make them all that way.

UI-LEAH-2077-2 18 Mar 2025

Why did you delete this alarm?

UI-LEAH-2077-2 19 Mar 2025

RESOLVED

UI-LEAH-2077-2 19 Mar 2025

RESOLVED

UI-LEAH-2077-2 19 Mar 2025

Updated the comment.

HD-DENBUG-298-1 26 Mar 2025

2 blank lines above/below test banner.

HD-DENBUG-298-1 20 Mar 2025

Done

HD-DENBUG-298-1 20 Mar 2025

I think it would be better to reject here if the saline bolus exec is IDLE (indicates there is no saline bolus in progress to abort).
I don't want to pend an abort flag (and open pressure limits) when no bolus in in progress.

HD-DENBUG-298-1 21 Mar 2025

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-307-1 02 Apr 2025

Done

DG-DENBUG-307-1 02 Apr 2025

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-230-1 02 Apr 2025

Done.

UI-DEN-17260-1 03 Apr 2025

Done

UI-DEN-17260-1 03 Apr 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

this is being used in the TreatmentTime.qml to resize the pause icon to match the design

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

fixed

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

instead of alias expost the property int width/height

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

moved the coloring inside of ProgressCircle

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove extra '_'

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

REMOVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

FIXED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

REMOVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

moved the funcitons

DD-LDT-1873-1 12 Aug 2025

Are we done with temporary code? Can we just remove it?

HD-DEN-16565-1 22 Dec 2023

Need doxygen group stuff here.

HD-DEN-14906-1 15 Mar 2023

Doesn't look like it.

DG-DEN-14763-1 15 Mar 2023

Done.

HD-DEN-14906-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH

RO-LEAH-273-1 05 Mar 2025

Remove blank line.

DG-DEN-14763-1 17 Mar 2023

Done