•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-14763-1 20 Mar 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14763-1 16 Mar 2023

Comment alignment.

DG-DEN-14763-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1 17 Mar 2023

I would suggest a more consistent naming for the enum items. "DISINFECT_USAGE_" rather than USAGE_INFO_ in the enum elements, and eliminating the "_DIS".
This would be more specific since "USAGE" and "INFO" are redundant, and "DIS" can be confused with "dis-", the Latin prefix.

HD-DEN-14860-1 20 Mar 2023

I think we need to re-visit this. Could impact dialysate heating negatively.

DG-DEN-14763-1 21 Mar 2023

Done

DG-DEN-14763-1 20 Mar 2023

This seems wrong.

DG-DEN-14763-1 21 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14999-2 28 Mar 2023

Does the new code result in one less TRUE comparison? Can rinsebackTimerCtr ever be greater than RINSEBACK_DONE_WARNING_TIME?

HD-DEN-16565-1 22 Dec 2023

These changes look wrong. This is UI comm check.

DG-DEN-14646-1 22 Mar 2023

Added DEBUG WARNING

LEAHI-APPLICATION-LDT-1616-1 18 Sep 2025

Thanks.
RESOLVED.

DG-DEN-14646-1 22 Mar 2023

Corrected

DG-DEN-14646-1 27 Mar 2023

Can we rename variable to reflect it is a timer counter at least?

DG-DEN-14646-1 22 Mar 2023

Alarm is based on a counter. The #define corresponds to a 100ms time.

RO-LEAH-273-1 05 Mar 2025

I think it makes sense for signal functions to be in the modes like it is now. It could be that the signal function is called from DD interface though.

DG-DEN-14646-1 22 Mar 2023

Corrected

HD-DEN-14999-2 27 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14999-2 26 Mar 2023

What's the significance of changing to U32? Is this being used as a timer?

HD-DENBUG-298-1 07 Mar 2025

Do we need to set presUFRate here (instead of volume)?

HD-DEN-14999-2 27 Mar 2023

Changing from U32 to S32. It is a relative ms timer (so wouldn't be negative), but I needed to initialize this to something less than zero so that alarm ranking logic will be forced to rank a brand new alarm (triggered 0 ms ago).

DG-DEN-14646-1 27 Mar 2023

Yes, and #define has "COUNT" in its name which was my point.

RO-LEAH-273-1 06 Mar 2025

These next 2 possibilities look to be handled the same. Can we combine the else if condition?

DG-DEN-14646-1 27 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 27 Mar 2023

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 06 Mar 2025

Include ROPump instead and add abstraction layer functions there as needed.

DG-DEN-14646-1 27 Mar 2023

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 13 Mar 2025

Fixed. Thanks!

HD-DEN-14860-1 27 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1 18 Mar 2025

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 27 Mar 2023

Fixed.

HD-DEN-14906-1 27 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14906-1 23 Mar 2023

Should venPres < venLowLimit be done outside if statement?

RO-LEAH-273-1 25 Mar 2025

Fixed. Thanks!

DG-DEN-14646-1 27 Mar 2023

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

DD-LEAH-230-1 31 Mar 2025

Can we remove 19600?

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove gradient

UI-DEN-14937-3 28 Mar 2023

Resolved.

DG-DEN-15014-1 28 Mar 2023

Done

DG-DEN-15014-1 28 Mar 2023

Done

DG-DEN-15014-1 28 Mar 2023

Done

DG-DEN-15014-1 28 Mar 2023

Done

DG-DEN-15014-1 28 Mar 2023

Done

DG-DEN-15014-1 28 Mar 2023

Updated the code.

DG-DEN-15014-1 28 Mar 2023

Changed it to TRUE/FALSE.

DG-DEN-15014-1 28 Mar 2023

Done

DG-DEN-15014-1 28 Mar 2023

This message is sent by UI to DG. Should be MSG_ID_UI_SET_DG_RO_ONLY_MODE.

DG-DEN-15014-1 28 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15014-1 28 Mar 2023

Doesn't look like this list is complete. In my opinion, init functions should be allowed to generalize here (e.g. Fill mode variables initialized.).

DG-DEN-15014-1 28 Mar 2023

RESOLVED in CODE WALKTHROUGH.