•  

Comment Results

Review Name Created Custom Fields Content
HD-DENBUG-162-2 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-163-1 02 Feb 2024

Maybe don't need this if we remove the switch statement.

HD-DENBUG-163-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-163-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-163-1 02 Feb 2024

Should this be an AND (not OR)?

HD-DENBUG-163-1 02 Feb 2024

Do we want to start the 10 second delay when pump is turned on or off?

RO-LEAH-273-1 06 Mar 2025

This should be >= medium && timeout.

HD-DENBUG-163-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16587-2 08 Feb 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 06 Mar 2025

Low state should be checked first since it has a safety implication and the above condition could prevent it for timeout period.
If low, we want to go to low state immediately (don't wait for timeout).

RO-LEAH-273-1 05 Mar 2025

Remove extra blank line.

RO-LEAH-273-1 06 Mar 2025

Add spaces between () and params (throughout this unit I see several). Also throughout, spaces between params.

HD-DENBUG-298-1 14 Mar 2025

The rest of the conditions will be filled up.

HD-DENBUG-298-1 14 Mar 2025

Is this condition right? What if we're in wait for pumps stop state? What state will saline bolus exec be in when we're done? Idle, right? Shouldn't we wait for that?

UI-LEAH-2077-2 18 Mar 2025

agree we should be consistent,
I put it this way since it helped to select vertically for the other part of the code to copy/paste and see all under each other to review the correct numbering.

UI-LEAH-2077-2 18 Mar 2025

it was the way defined in Denali,
let me know what your preference is for Leahi if you want different.

UI-LEAH-2077-2 18 Mar 2025

I think we should keep the ALARM_ID_TD_COMM_TIMEOUT as is, right?

UI-LEAH-2077-2 18 Mar 2025

There are references to "HD" in the text fields within the table (not enums, but titles and instructions and such).

UI-LEAH-2077-2 19 Mar 2025

Fixed.

UI-LEAH-2077-2 19 Mar 2025

Fixed

HD-DENBUG-298-1 20 Mar 2025

Done

HD-DENBUG-298-1 28 Mar 2025

Moved it to OperationModes

DD-LEAH-230-1 02 Apr 2025

Done.

DG-DEN-15014-1 28 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16565-1 22 Dec 2023

Where is this being called?

DG-DEN-16565-1 02 Jan 2024

Remove duplicate user code start comment.

HD-DEN-16391-3 03 Jan 2024

RESOLVED in CODE WALKTHROUGH

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

HD-DEN-16595-2 08 Jan 2024

Why was this block removed? We do not need to check of the empty bottles alarms anymore?

RO-LEAH-273-1 06 Mar 2025

Not initial. Low state.

DIALIN-DIAL-290-1 05 Feb 2024

Vinay is adding a new state. Sync with his pending change.

RO-LEAH-273-1 13 Mar 2025

Will be implemented with RO closed loop control.

HD-DEN-16518-1 15 Jan 2024

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

RO-LEAH-273-1 11 Mar 2025

Swap level and medium to get logic right. We want level >= LEVEL_STATE_MEDIUM.

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Updated

TD-LEAH-60-1 17 Mar 2025

Added.

HD-DENBUG-162-1 31 Jan 2024

Remove space before comma.

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

remove all commented code

HD-DENBUG-162-1 02 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1 17 Mar 2025

Yes, it is removed.

HD-DEN-16563-1 02 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16563-1 05 Feb 2024

RESOLVED in CODE WALKTHROUGH.

UI-LEAH-2077-2 18 Mar 2025

So can you align the "=" for 0..95 with the ones you added then?

UI-LEAH-2077-2 19 Mar 2025

Thanks for catching that.
Revert it back and fixed.

HD-DENBUG-162-1 05 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-162-1 05 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-162-1 25 Jan 2024

Use u32DiffWithWrap() function in utilities.

UI-LEAH-2077-2 19 Mar 2025

RESOLVED

HD-DENBUG-298-1 21 Mar 2025

Condition is not right. Blood leak recover is only relevant in treatment stop state, so we shouldn't care about that state if we're in dialysis.

HD-DENBUG-163-1 05 Feb 2024

Done.