Prefer to say RO only != TRUE so that any other value than 1 will cause RR alarm to be enforced.
RESOLVED in CODE WALKTHROUGH.
Needs param so caller can set it to FALSE too?
Standby Solo too? In case Dialin sends by proxy.
Need else for if FALSE - disable RO only.
Should take a BOOL param and set RO only flag to given BOOL. As it is, you can only set to TRUE - never FALSE.
This is really a BOOL (FALSE/TRUE). Why not make result a BOOL instead of U32?
Done
They had been removed.
Add timeWaitToFillMS to header.
Please use Changed and align
Check the diff of the last two commits.
Remove TODO?
Where is this called?
This is not user code. Next regen will restore this code. Do we really need to disable ECC error handling?
Needed?
Why was the = removed from the ternary ifs?
Remove extra blank line.
Where are these being triggered?
This will cause open loop control mode to have a minimum of 11% instead of 10%. For open loop, pwmDC is assigned a value at line 295. Do we still need the #define for the 10% pwm lower limit?
Fixed the code.
Remove space after cast.
These are not in HD where all go to one function. Should this be common code between DG and HD?
This looks wrong.
Remove extra space after >. Add () around inner conditions.
Done.
Add a comment here explaining that we don't need stage 2 stabilization for the regular 15 min adjustment.
I removed the old style software config test and this fixes the indents / brackets.
Recommend declaring this as an array here (1 for each sensor) so you don't need the switch statement.
the second level 'if' statement indentation is appeared to be missing for readability.
RESOLVED IN CODE WALKTHROUGH.
This effectively changes exemption start to time of valve open instead of close. We don't want to do that.
This row needs to be updated.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
