•  

Comment Results

Review Name Created Custom Fields Content
HD-DENBUG-163-1 05 Feb 2024

Done.

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Added

DG-DEN-16587-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 06 Mar 2025

If not doing anything for these conditions, add a comment at least saying we're not doing anyting so reader knows it's intentional and not an oversight.

HD-DENBUG-163-1 21 Feb 2024

Done.

HD-DEN-16666-1 08 Feb 2024

Should this be moved down inside if. Also, alarm below logs diffs. Why are we logging pressures?

HD-DENBUG-163-1 21 Feb 2024

Capitalize first letter of comment.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

UI-LEAH-2077-2 18 Mar 2025

Fixed.

HD-DENBUG-163-1 21 Feb 2024

RESOLVED in CODE WALKTHROUGH.

UI-LEAH-2077-2 19 Mar 2025

Sure,
All are now aligned.
Also, I updated other enums, if you do not want to, let me know.

DG-DEN-16587-1 15 Feb 2024

In pre-treat, there were transfers from one reservoir to the other that caused a false alarm. Figuring that out in SW at this level seemed overly complex. Also, the ticket notes this problem in Treatment only.

DG-DEN-16587-1 15 Feb 2024

Why is this reservoir check only happening in this state? Recommend creating a separate function to perform the check and call that function from gen idle exec function (i.e. do check in all gen idle states).

DG-DEN-16587-1 15 Feb 2024

RESOLVED in CODE WALKTHROUGH.

UI-DEN-16657-1 16 Feb 2024

The branch is deleted due to incorrect naming.

UI-DEN-16533-1 20 Feb 2024

RESOLVED
will be fixed later in the second round working on the current staging testing.

HD-DENBUG-163-1 21 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16672-1 14 Feb 2024

Rename to signalAirTrapPeriodicFill().

HD-DEN-16672-1 20 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16672-1 20 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16672-1 14 Feb 2024

Period is not really known by this module. Don't call out 15 minutes. Just say when requested or something like that.

HD-DEN-16672-1 20 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16672-1 27 Feb 2024

Since the utility is finding the difference of two numbers, I see the logic is common. for instance, On a positive case, u32DiffWithWrap(9000, 26000) where 9000 is the adjustment number and 26000 is the current timer value, the result is 26000-9000 = 17000. on a negative case, u32DiffWithWrap(9000,4000) where current timer value is 4000, the result would be 0xFFFF FFFF - 9000 + 4000 + 1. i.e: FFFF FFFF - 5000 + 1. Do you still see any concern?

UI-DEN-16533-1 21 Feb 2024

RESOLVED
I believe it has been explained in the comment.

UI-DEN-16533-1 20 Feb 2024

Wondering if last parameter value "3" should be "4"

UI-DEN-16533-1 20 Feb 2024

Just wondering if the last parameter be 4 instead of 3 since 3 is used in the previous line, I am just going by the pattern.

DRY-DEMO-DEN-16657-2 21 Feb 2024

will be followed up in the following CR:
http://devapps.diality.us:8060/cru/DRTSERVER-DEN-16657-1

HD-DEN-16672-1 20 Feb 2024

Is this definition still needed?

HD-DENBUG-163-1 21 Feb 2024

Done.

DIALIN-DENBUG-163-1 22 Feb 2024

Done.

DG-DEN-16674-1 22 Feb 2024

Yes this is still used in the deliver state. I changed the names in the #defines

DG-DEN-16674-1 22 Feb 2024

Is this 5% definition still used?
I don't think these are technically percentages (i.e. we do not mean 0.2%, we mean 20%).

DG-DEN-16674-1 22 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16672-1 27 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1 29 Feb 2024

CD1 is used to check the difference between CD1 and CD2. CD1 is not used to check the reading of acid.

HD-DEN-16693-1 29 Feb 2024

Done

HD-DEN-16693-1 27 Feb 2024

Remove blank line.

HD-DEN-16693-1 29 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1 29 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1 27 Feb 2024

Does this mean we aren't checking the CD1 sensor at all?

DG-DEN-16674-1 29 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1 29 Feb 2024

Done

DG-DEN-16674-1 29 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1 29 Feb 2024

These are Dialin commands? If so, prefix each enum with CMD_ and clarify this in comment.

DG-DEN-16674-1 29 Feb 2024

Done

DIALIN-DEN-16693-1 03 Mar 2024

Done

DIALIN-DEN-16693-1 27 Feb 2024

Remove extra blank line.

RO-LEAH-273-1 13 Mar 2025

Fixed. Thanks!

HD-DENBUG-298-1 07 Mar 2025

Done