Comment Search

Merged branch 'DEN-16657-UI-BN-S116-LogUpload' into DEN-16839-UI-BN-Whitney-1B1
6c122c0fa1daac67f03da7b8826305d463bfefd9

will close.

these are preferences and we are good.

I did not want to have the pump turning on/off if opened more than once. Stop while the user performs the action, then turn on when they are done. Maybe wait to turn on until user confirm.

Done

Update inputs

Looks weird aligning "=" with broadcast call inbetween.

Fixed. Thanks!

Fixed.

Add blank line before separator comment.

Just removed in firmware

This function is not necessary if the only valve states are open and closed.
In Denali, there were more state names and many of them only made sense to certain valves (e.g. FILL_RESERVOIR = OPEN and TO_DRAIN = CLOSED for VPo valve in Denali).
If we're not going to do that in Leahi, that's fine but then this function should be deleted since the mapping to energized and deenergized is very straight forward.
I recommend adding more state names like Denali had though.

HD s/b DD in return and brief sections.

Remove LED and load cell reset calls.
Why not call the deenergize function?

are we handling negative counts here? Per datasheet, If the count value is more than 8388608, Actual count value is "count -16777216".

VBTControl?

Use standard keywords like:
//FIXME :
//TODO :
to be listed in the QtCreator extension.

This is repeated here to make sure all the actuators are set in this function for completeness.

Capitalize the p in per.

Done

rename to updateMenu and move to main.qml where its being instantiated

Add blank line between different comment styles. I think doxygen messes up if you don't.

Keep going. Now 95 is wrong. Need comments to align with actual values throughout.

This CR should be closed due to bad branching. Should have been branched out of p1_staging.

Done

Done.