•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-16951-25 15 Jul 2024

No change on application for this story/branch.
Will be closed.

HD-DEN-15229-1 12 May 2023

Next state only requires door closed after confirm (when state is done). In meantime, door can be opened while pump is on and no alarm will occur and pump stays on I would think.

DD-LDT-319-1 21 Apr 2025

Done. somehow I see its all aligned in CCS editor.

TD-LDT-94-3 21 Apr 2025

Please add alarm/events.

DD-LEAH-210-5 28 Aug 2024

Change to "... executes periodic alarm management operations."

TD-LEAH-32-4 27 Aug 2024

Fixed.

TD-LEAH-32-4 27 Aug 2024

Fixed.

TD-LDT-94-3 22 Apr 2025

Shouldn't these bools be set to a specific value?

DD-LDT-319-1 22 Apr 2025

Done.

TD-LEAH-32-4 27 Aug 2024

I believe FPGA will have already sign extended the reading to 32-bits for us, so we should not be required to do those steps. I will confirm with Noe.

TD-LEAH-32-4 27 Aug 2024

Fixed.

LEAHI-APPLICATION-LDT-1733-1 24 Jul 2025

Updated

TD-LEAH-32-4 28 Aug 2024

Fixed.

LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

i reverted the min/max changes

RO-LDT-566-2 30 Jul 2025

fixed in renamed file. thanks.

TD-LDT-802-1 28 Jul 2025

This was in the wrong place.

TD-LDT-802-1 27 Jul 2025

I think dialyzer should always be bypassed (all sub-states) on transition into TxPaused state (main transition function at top of unit) just once - then we wouldn't need to worry about it in this function. Also, similarly, UF should always be set to zero rate in Tx Paused.

DD-LEAH-210-5 27 Aug 2024

Needs a /// comment above.

DD-LEAH-210-5 28 Aug 2024

Why not call this function?

DD-LEAH-210-5 28 Aug 2024

Why not call this function?

DD-LEAH-210-5 28 Aug 2024

Messaging is out of order. Alphabetize.

DD-LEAH-210-5 28 Aug 2024

Missing postPassed. I prefer we just generalize outputs for init functions to say unit variables are initialized.

DD-LEAH-210-5 28 Aug 2024

Remove.

DD-LEAH-210-5 28 Aug 2024

Remove - no reservoirs in DD.

DD-LEAH-210-5 28 Aug 2024

Remove CPLD include and replace with FpgaDD.h.

DD-LEAH-210-5 28 Aug 2024

Why is gio.h needed?

DD-LEAH-210-5 28 Aug 2024

Add details for broadcast message sent.

TD-LEAH-32-4 27 Aug 2024

Do we need to add alarm for DD and RO as well? there are few functions down needs the same resolution.

TD-LEAH-32-4 27 Aug 2024

Extra Semicolon.

TD-LEAH-32-4 28 Aug 2024

Do we still support this in Leahi? I heard in the last power management meeting that it is likely removed.

TD-LEAH-32-4 28 Aug 2024

I guess this is Write register ( not read- back)? you may change name as well to not to confuse with the same name in read page.

TD-LEAH-32-4 28 Aug 2024

To be removed?

TD-LEAH-32-4 27 Aug 2024

DG to DD.

DD-LDT-1473-1 28 Jul 2025

Remove extra blank line.

LEAHI-APPLICATION-LDT-1516-1 24 Jul 2025

test with simulator

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

RESOLVED

RO-LDT-566-2 30 Jul 2025

fixed in renamed file. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

Fixed. Thanks

RO-LDT-566-2 30 Jul 2025

removed. thanks!

RO-LDT-566-2 22 Jul 2025

Assume FP and DD would share this structure.
Why do we need it? TD is responsible for publishing this status.

RO-LDT-566-2 23 Jul 2025

Reword per comment in other units.

RO-LDT-566-2 23 Jul 2025

Same comment as temperatures. Consider similar approach where modes signal monitors to monitor differently as appropriate for mode instead of having monitor being aware of current mode.

RO-LDT-566-2 23 Jul 2025

Add isFlushComplete as input.

RO-LDT-566-2 01 Aug 2025

Comments to right of function prototypes are not required. If you add them, add them for all in a given header file.

RO-LDT-566-2 01 Aug 2025

fixed. thanks

RO-LDT-566-2 01 Aug 2025

fixed. thanks

TD-LDT-802-1 27 Jul 2025

Why not leave these un-commented?

TD-LDT-802-1 01 Aug 2025

Done

RO-LDT-566-2 01 Aug 2025

Align "=".