•  

Comment Results

Review Name Created Custom Fields Content
BOOTLOADER-LEAH-1415-1 30 Sep 2024

I have left the separating comments for future use.

DD-LDT-1473-1 28 Jul 2025

With the updated FPGA logic for continuous flow rate, doesn't need this variable anymore.

DD-LDT-1473-1 27 Jul 2025

Are we dosing UF in spurts like concentrates?

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 01 Oct 2024

Will be done once your changes available in staging.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 30 Sep 2024

Update brief and param to say that this function is only operating on the given pump. This and all functions with pump ID as param.

TD-LDT-736-1 29 Jul 2025

Fixed.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

Default for spacing is 0, so this can be removed.

RO-LDT-566-2 30 Jul 2025

fixed in renamed file. thanks!

RO-LDT-566-2 30 Jul 2025

removed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

added. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

it should be okay if we call when were not paused.. The idea is that if it was called the FP would ignore it since it was already in flush.

Changed the function to return a boolean.

RO-LDT-566-2 01 Aug 2025

fixed. thanks!

RO-LDT-566-2 01 Aug 2025

fixed. thanks!

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

removed it

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

removed

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

aligned

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

If this property is not being used, then can it be eliminated for now?

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Okay good to know. Added the slash

RO-LDT-566-2 01 Aug 2025

Remove blank line.

RO-LDT-566-2 30 Jul 2025

functions have been removed as we no longer need it. ( Controlling to flow )

LEAHI-DIALIN-LDT-261-1 27 May 2025

Do we have an enum for this message defined?

DD-LEAH-220-2 17 Sep 2024

As discussed, will be evaluated once we get more details on the sensor configuration/controls.

DD-LEAH-220-2 16 Sep 2024

I don't see Dialin override functions for these. Are you leaving these for Michael?

DG-DEN-15336-1 14 May 2023

Removed

TD-LEAH-32-4 28 Aug 2024

Yes, I will have controller/monitor call these in their init functions which will be called here. But until I have those higher level units, I don't want things to go uninitialized for now.

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

HD-DEN-15196-2 14 May 2023

Not many submodes in pre-tx that don't have substates - maybe cartridge install. Should call this when entering a submode with no substates.

HD-DEN-15196-2 14 May 2023

Should this be in transition function?

UI-DEN-15287-3 15 May 2023

RESOLVED

DD-LEAH-210-5 29 Aug 2024

Done.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15229-1 15 May 2023

Doesn't look removed. I'm talking about the call to handlePatientConnectionDoorOpened(). Do we need this now that door closed is required (as set in prior state)?

DD-LEAH-220-2 16 Sep 2024

Use \\\<.

TD-LDT-802-1 28 Jul 2025

The alarms have not been reserved until the we complete the alarms table.

TD-LDT-802-1 27 Jul 2025

Vectorcast won't be able to reach inside this if statement. It's dead code for now. Maybe better to just comment it out.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15229-1 15 May 2023

We are (I think now) allowing door open in first 2 states (UF and invert dialyzer), so should not be getting door open alarm when UI is prompting user to invert dialyzer. When we get to 3rd state (where we start requiring door to be closed), we are looking for user to connect patient and confirm. UI should be following along with our states and showing appropriate screens.
RESOLVED in CODE WALKTHROUGH.

BOOTLOADER-LEAH-1415-1 30 Sep 2024

Please see the updated code with the doxygen comments.

DG-DEN-15196-3 16 May 2023

Fixed. Thanks!

HD-DEN-15196-2 14 May 2023

should be "void sendOperationStatusEvent( void )"

DG-DEN-15274-1 16 May 2023

This looks wrong.