•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

moved above

HD-DEN-15229-1 15 May 2023

Reset flag in previous state.

DD-LEAH-210-5 29 Aug 2024

Done.

RO-LDT-566-2 30 Jul 2025

This was supposed to be a place holder for it. it was planned to be used in modes. After our previous discussion, this is wasn't the correct approach. It has been removed.

DD-LEAH-210-5 29 Aug 2024

Done.

DIALIN-DEN-15196-1 16 May 2023

Can you clarify? Events are organized by event id and by time. Currently the usage is looking like this:

>>> from dialin import HD
>>> hd = HD()
>>> hd.events.get_hd_events(23)
[]
>>> hd.events.get_hd_events(23)
[('1684258483', 3, 1, 255)]
>>> hd.events.get_hd_events(23,10)
[('1684258478', 3, 0, 255), ('1684258478', 3, 1, 255), ('1684258479', 4, 0, 255), ('1684258483', 3, 0, 255), ('1684258483', 3, 1, 255)
>>> from dialin.common.hd_defs import HDEventList
>>> hd.events.get_hd_events(HDEventList.HD_EVENT_OPERATION_STATUS.value,10)
[('1684258478', 3, 0, 255), ('1684258478', 3, 1, 255), ('1684258479', 4, 0, 255), ('1684258483', 3, 0, 255), ('1684258483', 3, 1, 255)]

where the user has the option to read the most recent event or a set of the event list.

I'll clarify with V&V. Feedback from john was to change the epoch time to a float.

DD-LEAH-210-5 30 Aug 2024

Done.

DG-DEN-15274-1 16 May 2023

Done

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Name of #define and doxygen comment do not make clear what max is for (i.e. download buffer).

DG-DEN-15274-1 17 May 2023

Purpose is to account for cooling of dialysate from reservoir to dialyzer. The faster Qd is, the less cooling will occur (less time to cool).
RESOLVED in CODE WALKTHROUGH.

LEAHI-SW-LDT-261-2 28 May 2025

Please refactor the _logFileNameHDSN to _logFileNameTDSN.

DD-LEAH-210-5 30 Aug 2024

Done.

LEAHI-SW-LDT-261-2 03 Jun 2025

fixed!

DD-LEAH-210-5 30 Aug 2024

Done.

LEAHI-SW-LDT-261-2 28 May 2025

Please remove this include.
This should be a leftover of the Denali project.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

RO-LDT-566-2 30 Jul 2025

Yes and has been moving to the temperature monitor

DD-LEAH-210-5 03 Sep 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

TD-LDT-802-1 01 Aug 2025

Done

DD-LEAH-210-5 03 Sep 2024

Done.

TD-LEAH-32-4 30 Aug 2024

Need to add DD and RO.

DD-LEAH-210-5 29 Aug 2024

Go ahead and remove init function call that you know we're not going to have.

DD-LEAH-210-5 30 Aug 2024

This is not a s/w unit. I think groups should be 1:1 with s/w units so that doxygen chapters align with s/w units to be tested. So this should probably be standby mode (TD or DD?).

RO-LDT-566-2 01 Aug 2025

fixed. thanks

RO-LDT-566-2 01 Aug 2025

Add blank line before return.

TD-LEAH-41-1 16 Sep 2024

Fixed.

TD-LEAH-41-1 16 Sep 2024

Need to add Alarm details.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Can we remove this now?

DD-LEAH-220-2 16 Sep 2024

I don't see Dialin override functions for read and error counter.

DD-LEAH-220-2 16 Sep 2024

Looks like "result = TRUE;" can be done just once above the if statement.

DD-LEAH-220-2 16 Sep 2024

Add a blank line between declarations and code.

DD-LEAH-220-2 16 Sep 2024

Remove "ed" from "filtered".

RO-LDT-566-2 01 Aug 2025

Remove extra blank lines.

DD-LEAH-227-1 01 Oct 2024

Done.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Align colon?

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 30 Sep 2024

Seems like we don't need a switch here. All sensors do the same thing. Remove switch.

DD-LEAH-227-1 30 Sep 2024

Are you doing overrides later?

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Please add a copy of the generated image as well.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED