•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15196-3 01 Jun 2023

Fixed. Thanks!

HD-DEN-15196-3 01 Jun 2023

Fixed. Thanks!

HD-DEN-15196-3 01 Jun 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15196-3 01 Jun 2023

Add current4thLevelState to header

HD-DEN-15196-3 01 Jun 2023

FIXED IN CODE WALKTHROUGH

HD-DEN-15196-3 01 Jun 2023

Add current4thLevleState to header.

DG-DEN-15455-1 01 Jun 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15455-1 30 May 2023

Add alarmDetectedPendingTrigger to header.

HD-DEN-15306-3 01 Jun 2023

Add alarmsBlockedTimer to header. Is alarmsBlockedTimer a timer or is it a counter?

BOOTLOADER-LEAH-1415-1 01 Oct 2024

thisStackMailBox is an input?

HD-DEN-15306-3 01 Jun 2023

A 10 second timeout timer, driven by the 50ms tick that drives the alarm state machine.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Remove test code.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Remove blank line.

LEAHI-SW-LDT-261-2 03 Jun 2025

fixed!

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 01 Oct 2024

Done.

LEAHI-TESTSUITES-LDT-1057-1 16 Oct 2025

Updated.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LDT-1873-1 08 Aug 2025

Restore after testing. This kind of thing is typically done with broadcast interval overrides from Dialin (not temporary hard-coded changes).

LEAHI-APPLICATION-LDT-1788-1 04 Aug 2025

Please fix the typo.

HD-DEN-15306-3 02 Jun 2023

Done. Changed each instance to the negative form for consistency.

RO-LDT-566-2 01 Aug 2025

fixed. thanks

HD-DEN-15306-3 02 Jun 2023

Done. Changed each instance to the negative form for consistency.

HD-DEN-15306-3 01 Jun 2023

Seems like we should be calling CPLD function here and in Fans, DialInFlow, and DGInterface too.

Also recommend calling the isACPowerLost() function in just one place - maybe alarm mgmt exec to give you your 10 sec alarm block. Maybe rename the function to checkACPowerLost() with no return value and make it static (private).

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

fixed

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

RO-LDT-566-2 01 Aug 2025

fixed. thanks

TD-LDT-802-1 31 Jul 2025

Dialysate temperature alarms should be TRUE for auto resume.

LEAHI-APPLICATION-LDT-1788-1 04 Aug 2025

Please use emit everywhere to be consistent with the rest of the code.

TD-LDT-802-1 01 Aug 2025

Done

TD-LDT-802-1 01 Aug 2025

I don't think we need this.

RO-LDT-566-2 01 Aug 2025

Remove extra blank line.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Doesn't look like this is being used externally or changed, can this be declared readonly?

LEAHI-TESTSUITES-LDT-1218-1 16 Oct 2025

Updated.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

LEAHI-TESTSUITES-LDT-1057-1 16 Oct 2025

Please remove all waits as they are not needed. If the object is not being found use the timeout instead.

     export_log_text = utility.get_object_from_names(names.exportLogsText, error_message = "export log text object missing", timeout_ms=1000)
LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Filename and class name (and all references to class name in file) do not match.

LEAHI-TESTSUITES-LDT-1057-1 16 Oct 2025

remove if not being used

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1536-1 04 Aug 2025

removed

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

removed

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

removed

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

updated

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

updated

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

These M sensors were treated differently above depending on beta h/w test config. Now that you have moved them down here, that differentiation is missing and appears to be doing the alpha thing only. Check w/ Vinay on desired handling. Do we even need this test config on beta build?

LEAHI-APPLICATION-LDT-2686-1 27 Oct 2025

done