•  

Comment Results

Review Name Created Custom Fields Content
RO-LDT-566-2 01 Aug 2025

Remove blank line.

RO-LDT-566-1 23 Jun 2025

Please follow the formats for Input and output (across the file/s)

RO-LDT-566-1 23 Jun 2025

Remove extra line

RO-LDT-566-1 23 Jun 2025

Please update the filename (seems CCS auto updates when changing file name)

TD-LDT-802-1 01 Aug 2025

Status should only be TRUE if msg accepted and signal sent. Move into if statement above.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

yes removed

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

only here so updated to readonly

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

i use it in VAlarmStatus::onActionReceive.. when we get a new alarm i clear the model and append the new steps/ images

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

i removed the dialog alarm one that the text is left aligned. If you agree i would like to keep the bottom bar alarmbar one as the text is centered

DD-LDT-1873-1 08 Aug 2025

Restore after testing.

DD-LDT-1873-1 08 Aug 2025

fpCommunicationStatus?

DD-LDT-1873-1 11 Aug 2025

Update comment too.

DD-LDT-1873-1 11 Aug 2025

Change name (RO to FP)?

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

Declare const, if possible.

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

RESOLVED

RO-LDT-1809-3 27 Aug 2025

Indents don't look right.

LEAHI-SW-LDT-926-1 28 Aug 2025

fixed!

LEAHI-SW-LDT-926-1 28 Aug 2025

RESOLVED

LEAHI-SW-LDT-2071-1 29 Aug 2025

RESOLVED

RO-LDT-1242-1 28 Aug 2025

Add blank line after declarations.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

M sensors are high pressure i.e. -1 to 10 bar
Also removed the check for test config for D9_PRES

HD-DEN-15306-3 02 Jun 2023

Add blank line between declaration and code.

Prefer we not assume bool and BOOL are the same. Use if statement and explicit assignment of TRUE to result if all conditions are true.

First condition seems backward.

Second and third conditions seem problematic. You will never trigger an AC power loss alarm. Should remove them I think.

DD-LEAH-227-1 01 Oct 2024

Done.

HD-DEN-15196-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3 01 Jun 2023

This is technically a timer counter based on task tick of 50ms.

DD-LEAH-225-1 16 Oct 2024

Why the "XXX" in alarm enums?

DD-LEAH-227-1 01 Oct 2024

Done.

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3 01 Jun 2023

This was safer the other way. Why change?

DD-LEAH-227-1 30 Sep 2024

There does not appear to be any variable named tempValuesForPublication. If this is intended to be a general description, use plain English instead of camel case.

HD-DEN-15306-3 02 Jun 2023

Still need header fixed.

LEAHI-APPLICATION-LDT-713-1 13 Jun 2025

As a U16, this should be 'Short_to_bytearray'

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3 02 Jun 2023

Remove this condition.

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-TD-FIRMWARE-LDT-3126-1 02 Mar 2026

I think this can just be an else since resume is the only remaining possibility.

LEAHI-APPLICATION-LDT-713-1 16 Jun 2025

RESOLVED

DD-LEAH-225-1 16 Oct 2024

dialysatePumps[] is an input.

LEAHI-TESTSUITES-LDT-2741-1 03 Mar 2026

changed function name and code

LEAHI-SW-LDT-261-2 05 Jun 2025

RESOLVED

DG-DENBUG-318-1 05 Jun 2025

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15306-3 02 Jun 2023

RESOLVED IN CODE WALKTHROUGH

RO-LDT-566-1 23 Jun 2025

fixed. thanks!

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed.

LEAHI-APPLICATION-LDT-1021-1 24 Jun 2025

update files that I edited this portion

LEAHI-APPLICATION-LDT-450-1 09 Jun 2025

To ensure that specific components are not referenced anywhere, I do not assign an ID to them.
As for the name, however, we'll ensure that it is only added if it needs to be included in the SquishQt integration test.

LEAHI-APPLICATION-LDT-450-1 09 Jun 2025

remove commented out line?

LEAHI-SW-LDT-450-1 11 Jun 2025

fixed

LEAHI-APPLICATION-LDT-450-1 12 Jun 2025

RESOLVED