Comment Search

These are temporary test intervals, right? Please revert when testing is completed.

Done, thank you

To avoid resetting data and ovdata to zero when we send an override on top of another override.
Using the data value to check if the control should be handled or not as the ovdata is been assigned to data in all set functions

I believe this should be in the response, so the situation that the script exists and can be executed, and is executed, and has some issues, is covered too.
First line in the else block.

Added

This seems unnecessary now with your new function doing this all the time. Consider removing.

RESOLVED in CODE WALKTHROUGH.

Done.

Fixed

If all timeouts are set to 3000, please set it as the default for the function parameter to avoid passing it everywhere.

Are we confirmed for removal? Would there be a situation we need this override that the proxy cmd could not satisfy?

Converting U16 to U32. Presumably, U16 will wrap back to zero when it gets to 65535. We don't want our U32 to wrap, so we need to do something to handle this conversion properly.

mouseClick(waitForObject(utility.findChildByText(post_treatment, config.AUTO_EJECT), 2000))

At present all English text-only content are maintained in config,py file

RESOLVED

RESOLVED

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean NashMichael Garthwaite please confirm

this shouldnt be over 0 so I removed

I don't think we need to call setPressureLimitsToOuterBounds() either. The signal function will indirectly cause that function to be called later.

v non-capital
For these little dialogs, we do not want the dark overlay, though.

Please align the semi-colons ( ; ), colons ( : ) , and dots ( . ) (when/where)ever you see them not aligned with the rest.

Please do not use == false or == true for an already boolean value/function.
just use:

if ( ! vIndex.isValid() || vIndex.row() < 0 || vIndex.row() >= rowCount()  )

I guess, you should still need 'TestingActivated' check, due to a reason when system team wants to change the states as part of their testing.

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

Fixed