•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3103-1 17 Feb 2026

changed.

LEAHI-DD-FIRMWARE-LDT-3103-1 17 Feb 2026

done.

LEAHI-DD-FIRMWARE-LDT-3103-1 17 Feb 2026

done.

LEAHI-DD-FIRMWARE-LDT-3103-1 17 Feb 2026

changed.

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

added a todo for testing it after we have the new beta 2 units.

LEAHI-TD-FIRMWARE-LDT-473-2 17 Feb 2026

convert to switch case

HD-DEN-15306-3 02 Jun 2023

Remove space between ().

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-225-1 16 Oct 2024

For target/measured speeds, can they be negative? If so, does negative indicate reverse? Can pumps be run in both directions?
Clarify these things in comments.

DD-LEAH-225-1 16 Oct 2024

This will always fail. Until calibration record available, set this to TRUE.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 30 Sep 2024

We could say calibration is an input.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Should it be FPGA_PERS_ERROR_P18_COND_SENSOR instead of P9?

LEAHI-SW-LDT-261-2 05 Jun 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 15 Sep 2025

RESOLVED

LEAHI-SW-LDT-261-2 05 Jun 2025

RESOLVED

LEAHI-SW-LDT-261-2 05 Jun 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-3372-2 02 Mar 2026

parameter check happens in getTeensyCondId

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed.

LEAHI-TD-FIRMWARE-LDT-2932-1 17 Feb 2026

/// -is this does not recognize by doxygen ?

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed.

RO-LDT-566-1 23 Jun 2025

Remove extra line

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

fixed!

LEAHI-SW-LDT-907-2 04 Aug 2025

oh I forgot to remove when debugging, will remove

LEAHI-TESTSUITES-LDT-3060-1 26 Feb 2026

please update to use the wait for and remove if statement..

mouseClick(waitForObject(prescriptions_menu_object, 2000))

Please update throughout test case to use the waitForObject and a timeout and remove the if check

LEAHI-DD-FIRMWARE-LDT-2198-1 15 Sep 2025

Read FPGA P25 status once at top of P25 if statement into a local var and use that in these if conditions so you don't have to keep calling the fpga function.

LEAHI-APPLICATION-LDT-2071-1 29 Aug 2025

We should ask caryn on how we can display these and then I can update all these commented out lines in all the components for the main treatment screen

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Align "=".

LEAHI-DD-FIRMWARE-LDT-2198-1 15 Sep 2025

Consider making function name a little clearer that we are getting the status from the FPGA.

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

updated

LEAHI-DD-FIRMWARE-LDT-3372-2 03 Mar 2026

Doesn't look like this switch statement is doing anything. Can we remove it?

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Remove comment? And TODO comments should be all caps.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Done.

DD-LDT-1873-1 08 Aug 2025

Done.

LEAHI-DD-FIRMWARE-LDT-2198-1 16 Sep 2025

Are we still supporting FMI pumps?

DD-LDT-1873-1 08 Aug 2025

Done.

DD-LDT-1873-1 08 Aug 2025

We are broadcasting BC data every 50ms? Why?

DD-LDT-1873-1 08 Aug 2025

Per comment, change name to "adjustedPrimaryHeaterTargetTemp".

DD-LDT-1873-1 08 Aug 2025

If this function only supports D5 heater, why do we ask for a heater param? Why not refactor function to "void signalToResetPrimaryHeaterAdjustedTargetTemp( void )"?

LEAHI-APPLICATION-LDT-1788-1 04 Aug 2025

Use the checks as check blocks, and avoid if, elses.

if ( ! check1 ) { return; }
if ( ! check2 ) { return; }
// the pass block
....
LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

removed.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Should we remove this whole function?

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

done

LEAHI-DD-FIRMWARE-LDT-3372-2 04 Mar 2026

how are unsigned integers negative?

LEAHI-DD-FIRMWARE-LDT-3103-1 17 Feb 2026

changed.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

removed

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

removed

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

done.

LEAHI-DD-FIRMWARE-LDT-3344-1 17 Feb 2026

I have added the mentioned ones.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Ive added the markers for DD. Since the IOFP is only one float, i thought markers for IOFP weren't needed.