Comment Search

done.

Can this stuff down here be done in a separate function that is called here? This function is too big.

Looks like publish function moved to monitor (priority task). I actually don't think publish function should have moved, but if we move it we need to change interval timing here.

Any reason why pwmInCount can't just be a U32?

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

the 2nd if statement for beta 1.0 is an ask from systems team to raise fault alarm if user by mistake enable Beta 2.0 config when Beta1.0 is active

changed.

removed.

( F32 percentage )
{
}

We do need an else if here for when user does change the blood flow rate. In that case, we would want to go to run state where we would run continuously at the requested rate without ramping anymore. Ask Nico which message UI sends when user changes blood flow rate.

And we need another else if for when user asks to pause blood prime and we would stop BP (and maybe close art/ven pinch valves) and go to pause state.

We will be merging the latest staging and resolve the conflicts after the CR approval.

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

TBDL: Let's discuss more later.

I do not understand the intent of this function call that only emits a signal.
This is the call graph that I do not see as necessary (correct me if I am wrong):
PreTreatmentCreateContent.qml (PreTreatmentCreateContent.Clear) -> vTreatmentCreate.doClear() -> VTreatmentCreate::doClear() -> emit VTreatmentCreate::didClear() -> vTreatmentCreate.onDidClear() -> PreTreatmentCreateContent (_root.clear() )
From the PreTreatmentCreateContent.qml it goes into C++ and comes back in the same caller (PreTreatmentCreateContent), why?

I bleieve we should follow the same stacks to screens clear calls explained in the following comment:
http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-1616-1CFR-76254

made changes as per comment

Updated

Add detail for alarm.

updated as per comment

This is part of the issue for the intermittent fails. You are forcing the opmode to service which changes the screen to device settings. But the bottom menu is on the wrong index. Correct navigation is first goingto standby then pressing the bottom menu option for settings. Then enter password then finally change opmode to service.

This can be updated to

    def verify_automatic_vitals_noRejection_Reason():  

    MAX_WAIT = 5 * 60 * 1000  # 5 minutes in seconds
    
    test.verify(waitFor( lambda: vitalsrequest == True, MAX_WAIT), "UI Sending the request to FW")
    td.td_vitals_adjustment_response(vRejectionReason=0)
    td.td_vitals(systolic = 80, 
        diastolic   = 60, 
        heartRate   = 140 )

            
    blood_pressure  = waitForObjectExists(names.o_treatmentHome_bloodPressure_LabelValue).topText
    test.compare("70"+"/"+"50", blood_pressure,"Blood pressure value should be ->"+str("80"+"/"+"60"))
    heart_rate = waitForObjectExists(names.o_treatmentHome_heartBeat_LabelValue).topText
    test.compare("120", heart_rate,"Heart Rate value should be ->"+str(120))

added status to list model

Don't call function in function call. Set local var to scalar, then pass local var as param.

remove #if 1 and add a TODO with this comment

We've been using capital F. Let's be consistent.

Updated the method

if sensor id is not in the finite state enum value , it return 0 and here it calculate for P9