•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

Yes since you're not using the return value in execOpModes()

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025
  • If only the dialog becomes visible, we should do that, and when it is closed, you should not call the function.
  • The naming is confusing, since it does not check; it only fills the fields with the values.


Execution Review

  • When you populate the values from the previously set K and Ca, a notification appears indicating a duplicate entry.
LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

From what I can see, these two signals are no longer in use.
Please ensure that you notify the user of rejection from FW.
And move forward only when FW accepts the request.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

updated and added this behavior

LEAHI-TD-FIRMWARE-LDT-473-2 20 Feb 2026

Move pop to be right after last structure to be packed.

LEAHI-TD-FIRMWARE-LDT-473-2 20 Feb 2026

update params in header.

LEAHI-TD-FIRMWARE-LDT-473-2 19 Feb 2026

Fixed

LEAHI-TESTSUITES-LDT-3014-1 20 Feb 2026

this will work but can be updated to be more flexible and take into account if HeparinSringePump is set to enabled or disabled.. I suggest checking the system.conf first specfically the HeparinSyringePump and if it is set to 1 then the 3 heparin parameters are visible.

IF HeparinSyringePump is set to 0 then heparin is defeatured and those 3 heparin parameters are not visible and will fail to find and set those values.

LEAHI-TD-FIRMWARE-LDT-3126-1 02 Mar 2026

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

LEAHI-TD-FIRMWARE-LDT-473-2 19 Feb 2026

This will be gone once we have institutional records, do you still want me to move it to a separate func?

LEAHI-TD-FIRMWARE-LDT-473-2 18 Feb 2026

Should we cast these to (S32)?

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

Updated

LEAHI-APPLICATION-LDT-1616-1 18 Sep 2025

Name updated to doPopulateAcidConcentrate() and to only call when visible and clear notification when not.

LEAHI-DD-FIRMWARE-LDT-2198-1 10 Sep 2025

Read page starts at 0x200 now.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

brought it back.

LEAHI-TD-FIRMWARE-LDT-3126-1 02 Mar 2026

Still need to range check the rate, reject if out of range, accept and assign if in range.

LEAHI-DD-FIRMWARE-LDT-2198-1 18 Sep 2025

I have removed multiple M4 valve control across in DD. IO/FP will govern the M4 valve control.

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

Do we really need a start state? Can't we just start in off state.

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

We don't need this complex logic . use getFPGAVersions() function

LEAHI-TD-FIRMWARE-LDT-473-2 20 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3539-1 18 Feb 2026

This alarm does not belong here. Put it back where it was before.
In the next table below, the alarms are sorted by rank. But this property table is sorted by alarm ID #.

LEAHI-DD-FIRMWARE-LDT-3372-2 05 Mar 2026

comment alignment issue

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed.

LEAHI-TESTSUITES-LDT-3060-1 23 Feb 2026

Now I am verifying Heparin containers are visible or not in create rx screen

LEAHI-TD-FIRMWARE-LDT-1903-8 20 Feb 2026

Should we specify that power level is now a duty cycle percentage (0..100%)?

LEAHI-TD-FIRMWARE-LDT-1903-8 20 Feb 2026

We have a FRACTION_TO_PERCENT_FACTOR in Common.h that we can use when we need 100.0.

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025
  • Please put both the K and Ca ranges under the category: [Acid Concentrate Ranges]
    rename them like:


[Acid Concentrate Ranges]
Acid_Concentrate_Potassium_Def
Acid_Concentrate_Potassium_Min
Acid_Concentrate_Potassium_Max
Acid_Concentrate_Potassium_Res

Acid_Concentrate_Calcuim_Def
Acid_Concentrate_Calcuim_Min
Acid_Concentrate_Calcuim_Max
Acid_Concentrate_Calcuim_Res

LEAHI-TD-FIRMWARE-LDT-3126-1 20 Feb 2026

signal function will take us out of blood prime, so no reason to change state here. We would not want to go to run state even if we weren't leaving - run state is for when user changes blood flow rate which they have not done here.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Execution Review:

Close the dialog when you receive the accepted confirm response from the FW.

LEAHI-TD-FIRMWARE-LDT-3126-1 20 Feb 2026

In this state, we still need to signal transition to dialysis when target volume is reached (same as in ramp state).
We also need to look for user request to pause (same as in ramp state).

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

i cant update the property name to default because its a reserved keyword in qml. I also cant change actualValue to value because we already have a value property that serves as the main value for this component. Actual value is intended only for the refresh to update with the "actual" value set in c++.

LEAHI-TESTSUITES-LDT-2819-1 03 Mar 2026

what are the ga_formater.py files for?

LEAHI-DD-FIRMWARE-LDT-3372-2 04 Mar 2026

typedef enum Conductivity_Models

Unknown macro: { STANDARD, ///< standard equation for conductivity ALY_LINEAR, ///< Aly's high range model for conductivity UPDATED_STANDARD, ///< Updated stand equation with a linear transformation. NUM_OF_MODELS, ///< Number of models used for conductivity calculation. }

COND_MODELS_T;

Its enumeration , if user send -1, -1 < NUM_OF_MODELS, this check passes

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

good to have doxygen comments on right hand side

LEAHI-TD-FIRMWARE-LDT-473-2 18 Feb 2026

Can we uncomment this and send the limits to the UI?

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

didValidationPass() is still being used and the slot in in PreTreatmentCreateContent. The didValidationFail() is no longer being used. The user notified of rejection by that failing fw components border changing colors and the confirm button is disabled until they try again. Do we want an additional message notifying the failure?

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

They were removed accidentally is what my understanding is, identify issued after commit cfa8ae2.
reverted the changes with cherry picking the commits

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Please just "canOFF" is sufficient.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

done brought back.

LEAHI-DD-FIRMWARE-LDT-3344-1 19 Feb 2026

changed the result to U16.

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

Its not required, HW should be auto detected and initialized without any user configuration.

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

Fix alignment.

LEAHI-DD-FIRMWARE-LDT-3344-1 18 Feb 2026

Should just be one return statement in function. Set a local variable where you have returns, remove the returns, and then just return the local variable at the end of function (like it was before).

LEAHI-TD-FIRMWARE-LDT-3539-1 20 Feb 2026

Updated

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

removed.

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed.

LEAHI-DD-FIRMWARE-LDT-3344-1 20 Feb 2026

Removing all the review comments and created a ticket to handle it in separate ticket -LDT-3563

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

LEAHI-TESTSUITES-LDT-2278-1 05 Mar 2026

initialize request variable

vitalsrequest = None