•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-1196-6 30 Sep 2025

Appears to be dialysate to dialyzer flow rate.

LEAHI-DD-FIRMWARE-LDT-2138-1 06 Oct 2025

Align comments in all of this switch cases

LEAHI-TD-FIRMWARE-LDT-4505-1 06 Jul 2026

Do we still need this?

LEAHI-APPLICATION-LDT-1440-1 07 Oct 2025

Updated.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

1 blank line here is sufficient.

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

INVALID_REQUEST_FORMAT

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2264-1 07 Oct 2025

Always keep the adjustment Trigger property for the messages you receive.
The goal is to notify the UI when all the properties are set after receiving the message, which, on binding, is triggered one by one when assigned and if changed.

LEAHI-APPLICATION-LDT-2264-1 08 Oct 2025

Change totalCount to a read only property?

LEAHI-APPLICATION-LDT-1440-1 25 Sep 2025

Remove radius for progress bars with markers.

LEAHI-APPLICATION-LDT-1440-1 01 Oct 2025

Prevent slider from going below delivered volume in real-time (bind to value).

LEAHI-TD-FIRMWARE-LDT-1903-8 23 Feb 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Updated

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Updated

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

added

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

Message ID and comment in model for 0xBB needs to be updated in MTreatmentAdjustRequests.h

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

0xBB has 2 parameters.. [mId, mConfirm]

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

thanks
fixed.

LEAHI-TESTSUITES-LDT-2278-1 06 Mar 2026

Updated the test.compare values

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

fixed

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

updated and reverted this

LEAHI-TESTSUITES-LDT-2278-1 05 Mar 2026

One issue encountered is the if BP Cuff is disabled then teh measure button will also be disabled. So as prep one thing to do before running the tests is to verify the bp cuff is enabled or change the variable in teh system.conf

LEAHI-DIALIN-LDT-2300-1 22 Sep 2025

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

LEAHI-DIALIN-LDT-2300-1 22 Sep 2025

Replace "dg" with "dd".

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

updated

LEAHI-TESTSUITES-LDT-2819-1 05 Mar 2026

Removed this file

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1616-1 19 Sep 2025

do not show show when in create Rx screen

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

removed check. the check now happens on before the get.

LEAHI-DIALIN-LDT-2300-1 22 Sep 2025

No timestamp?

LEAHI-TESTSUITES-LDT-2085-1 25 Sep 2025

Typo 'standy'

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

so the isActive is the internal property of ValueAdjuster and it is binded to the c++ property of <*>set. Similar to how we binded the value to the c++ property

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025
  • Change the vSet to vActive to make it clearer.

  • Please use .isActive = vActive after addressing the above comment.
LEAHI-APPLICATION-LDT-1616-1 19 Sep 2025

Remove this and update c++ vCreate onRelease

LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

LEAHI-DD-FIRMWARE-LDT-3372-2 05 Mar 2026

All comments should start with capital letter

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Add blank line after declarations.

LEAHI-APPLICATION-LDT-1440-1 30 Sep 2025

Colors in denali differ from new leahi design.

LEAHI-TESTSUITES-LDT-3060-1 04 Mar 2026

change to mouseClick(waitForObject(utility.findChildByText(main_menu_container, config.PRESCRIPTIONS)), 2000 )

LEAHI-TESTSUITES-LDT-2085-1 30 Sep 2025

Since the issue is fixed.
RESOLVED on behalf of Tiffany Mejia.

LEAHI-DD-FIRMWARE-LDT-2198-1 25 Sep 2025

Why the extra leading zeroes? If you want to ensure the literal is treated like a U32, you can do 0x00000001 or simply 1U, but I suspect the compiler will default to 32 bits anyway.

LEAHI-TD-FIRMWARE-LDT-2240-1 06 Jul 2026

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

LEAHI-APPLICATION-LDT-2264-1 07 Oct 2025

Lets discuss and remove the NumPad from the ModalDialog that is the parent of many other dialogs which do not need NumPad.
In this case it should be in the TreatmentAdjustmentVitals.qml

LEAHI-APPLICATION-LDT-2264-1 10 Oct 2025

RESOLVED

LEAHI-SW-PLUGINS-SIM-LDT-2264-1 10 Oct 2025

Are these two imports needed?

LEAHI-DIALIN-LDT-2264-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Change from READONLY to RANGESET and change ultrafiltrationVolumeRes to ultrafiltratoinVolume.

LEAHI-APPLICATION-LDT-1440-1 06 Oct 2025

Add console.log message.