•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

fixed. thank you.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

called it from here. Fixed it. Thank you

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Removed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Add spaces around void.

LEAHI-FWCOMMON-LDT-2116-1 21 Nov 2025

Consider increasing even more. May 50 or even 100.

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Add blank line between declarations and code.

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Took note that the FPGA interface is at the driver level.

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Fixed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Add blank line between declarations and code.

LEAHI-SW-SCRIPTS-LDT-2727-1 24 Nov 2025

added

LEAHI-DD-FIRMWARE-LDT-2030-2 26 Nov 2025

Fixed. Thank you.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Add space between } and type name.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Remove extra blank line.

LEAHI-TESTSUITES-LDT-1802-1 26 Nov 2025

please keep this CR to only items used for this CR.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Remove extra blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

copy right missing

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

bicart? Can we spell this out since this will be main description of this unit in SDD? Assuming bicart = dry bicarbonate cartridge?
Also, this unit appears to control bicarb chamber - not just cartridge - so we should mention that here.

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Can't we just do all of this in the start state?

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

order of include file is not proper

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Add comments to describe new variables.

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Add blank line between declarations and code.

LEAHI-DD-FIRMWARE-LDT-2030-2 25 Nov 2025

Packing only needed if it's used for transmission. I don't see this structure being broadcast anywhere.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Done

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

No param, so remove this line.

LEAHI-TESTSUITES-LDT-2174-1 26 Nov 2025

There may be a test.endSection() missing somewhere as the report shows a section not sectioned out. Please update regenerate report and review and reupload.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

structure packing statement missing

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-RO-FIRMWARE-LDT-2116-1 22 Nov 2025

Fixed. Thanks

LEAHI-RO-FIRMWARE-LDT-2116-1 20 Nov 2025

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Why is controller bypassing driver to get to fpga?

LEAHI-TESTSUITES-LDT-2174-1 26 Nov 2025

remove visible property

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Why not D64 in this case?

LEAHI-TESTSUITES-LDT-2174-1 24 Nov 2025

please align parameters

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Remove extra blank line.

TEENSY-BOARD-LDT-2004-6 24 Nov 2025

Fix indent.

LEAHI-RO-FIRMWARE-LDT-2116-1 21 Nov 2025

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1886-1 25 Nov 2025

Seems backward. Why is inactive = TRUE? I would expect TRUE to indicate that the optical sensor is detecting home (retracted) position.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Use /// here so doxygen will pick it up.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

///

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

Add space between } and type name.

LEAHI-DD-FIRMWARE-LDT-2004-1 21 Nov 2025

measurementSettingsTX is an output.

LEAHI-RO-FIRMWARE-LDT-2116-1 24 Nov 2025

is this year correct ?

LEAHI-DD-FIRMWARE-LDT-2004-3 21 Nov 2025

Should D64 also be in the #ifndef below? The DryBiCart state machine controls this valve too.

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

Please arrange it in alphabetical order

LEAHI-DD-FIRMWARE-LDT-2030-2 24 Nov 2025

alignment of comments not proper, check all other places