•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-3433-1 06 Mar 2026

added new image

LEAHI-APPLICATION-LDT-3433-1 06 Mar 2026

updated

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

updated.

LEAHI-TD-FIRMWARE-LDT-1415-3 06 Mar 2026

Removed

LEAHI-DD-FIRMWARE-LDT-3372-2 05 Mar 2026

above comment applicable here .

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Same question.

LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

LEAHI-TD-FIRMWARE-LDT-4160-1 07 Jul 2026

Rename to AlarmTableResposnePayload

LEAHI-DD-FIRMWARE-LDT-4733-1 09 Jul 2026

fixed. thanks!

LEAHI-DD-FIRMWARE-LDT-4733-1 08 Jul 2026

Align comment.
Clarify (at least in comments) that these macros are for FPGA count conversions.

LEAHI-TD-FIRMWARE-LDT-4040-1 14 Jul 2026

Add extra line (should be 2 lines) after test support banner.

LEAHI-TD-FIRMWARE-LDT-4040-1 10 Jul 2026

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line before return statement.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line between declarations and rest of function code.

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Add blank line before return statement.

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

I think we can do this check now, right?

LEAHI-TD-FIRMWARE-LDT-4149-1 09 Jul 2026

If this reserved2 is a U32, next register would be at 288 (not 285). Should we make reserved2 a U08?

LEAHI-APPLICATION-LDT-4919-1 09 Jul 2026

test to see if i can use this to change headbar.activestack.

LEAHI-DD-FIRMWARE-LDT-4410-3 11 Jul 2026

its mixing control interval

LEAHI-TD-FIRMWARE-LDT-1903-8 23 Feb 2026

You have these MIN/MAX definitions in both this unit and AirPump unit. Can we put these in header file for this unit and remove from AirPump unit?

LEAHI-DIALIN-LDT-2300-1 22 Sep 2025

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

It does not seem like the bool parameter of this signal is useful,
remove the bool and just emit the signal.

LEAHI-APPLICATION-LDT-1616-1 24 Sep 2025

RESOLVED

LEAHI-DIALIN-LDT-2300-1 25 Sep 2025

Done

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

build switch fixes will be completed in the v2 conductivity sensor branch. Per what was agreed on back in November:

J1 - P9
J2 - P18
J3 - D17
J4 - D27
J5 - D29
J6 - D43
No sensor - D74 (redundant, so we should be able to live without it in short run)

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Remove extra blank line.

LEAHI-TD-FIRMWARE-LDT-1415-3 06 Mar 2026

I think we should just call signalInitiatePressureStabilization( USE_NORMAL_STABILIZATION_PERIOD );

LEAHI-DD-FIRMWARE-LDT-3372-2 06 Mar 2026

Remove blank line.

LEAHI-APPLICATION-LDT-1440-1 09 Oct 2025

Updated.

LEAHI-APPLICATION-LDT-2264-1 07 Oct 2025

Use ACTION_VIEW_CONNECTION instead, to be consistent, since it is directly connected to the _GuiController.

LEAHI-APPLICATION-LDT-2264-1 10 Oct 2025

RESOLVED

TD-LDT-1886-7 29 Sep 2025

Partial Close?

TD-LDT-1886-7 29 Sep 2025

1760 is now the expected nominal count for full travel? If 1760 is center of bell curve and 1700 is minimum, then 1820 should be max (not 1900)?

LEAHI-DD-FIRMWARE-LDT-4733-1 08 Jul 2026

Did you get a chance to test this alarm and uncomment the code?

LEAHI-TD-FIRMWARE-LDT-4029-1 09 Jul 2026

Move up one row to alphabetize.

LEAHI-TD-FIRMWARE-LDT-4028-2 14 Jul 2026

currentInstallState is an input.

LEAHI-TD-FIRMWARE-LDT-4049-1 14 Jul 2026

Initialize post treatment too.

LEAHI-DD-FIRMWARE-LDT-2198-1 24 Sep 2025

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Remove blank line.

LEAHI-DD-FIRMWARE-LDT-3603-1 06 Mar 2026

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-TESTSUITES-LDT-2085-1 25 Sep 2025

fixed typo

LEAHI-DD-FIRMWARE-LDT-4733-1 09 Jul 2026

fixed. thanks!

LEAHI-TESTSUITES-LDT-2085-1 29 Sep 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-4614-1 08 Jul 2026

Space inside parenthesis. update across the file.

LEAHI-TD-FIRMWARE-LDT-4029-1 13 Jul 2026

Why did you remote call to init function here? Is it initialized somewhere else?

LEAHI-TD-FIRMWARE-LDT-4040-1 10 Jul 2026

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

LEAHI-DD-FIRMWARE-LDT-3735-1 14 Jul 2026

Make sure Dialin gets these too when you merge.