•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-1196-6 30 Sep 2025

Please use 0.0F (since its float variable).

LEAHI-DD-FIRMWARE-LDT-1196-6 30 Sep 2025

Check the current Gen dialysate sub state.

LEAHI-APPLICATION-LDT-1440-1 29 Sep 2025

can you revert removing /HeaderBarPopup.qml and AlarmButtonRow.qml

LEAHI-TESTSUITES-LDT-2085-1 30 Sep 2025

we talked and am resolving.
RESOLVED.

LEAHI-DD-FIRMWARE-LDT-2138-1 06 Oct 2025

Done.

LEAHI-APPLICATION-LDT-1440-1 01 Oct 2025

Change TCH: Ultrafiltration Edit Button to TCH: Ultrafiltration Section Adjustment Button.

LEAHI-APPLICATION-LDT-2264-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-2264-1 08 Oct 2025

VTreatmentAdjustmentVitals.cpp

LEAHI-DIALIN-LDT-2264-1 10 Oct 2025

RESOLVED

LEAHI-SW-PLUGINS-SIM-LDT-1440-1 10 Oct 2025

the naming convention for the objects is to have the type at the begining of the name.
eg.
allSentButton => tbAllSent
prRequestLabel => lblPrRequest

LEAHI-SW-PLUGINS-SIM-LDT-1440-1 10 Oct 2025

always use space around the operator and wrap them in parenthesis.

TD-LDT-1886-7 29 Sep 2025

Did we remove support for this NO_PINCH_VALVES build switch? If so, remove the switch.

TD-LDT-1886-7 29 Sep 2025

Add doxygen comment to right.

TD-LDT-1886-7 29 Sep 2025

Why is this removed?

TD-LDT-1886-7 29 Sep 2025

I don't think we want to keep this change.

LEAHI-TD-FIRMWARE-LDT-3126-1 23 Feb 2026

Stop button is a "hard" pause which would take us to Treatment: Paused state (out of blood prime completely).
We want to go to our internal paused state when UI sends us a "soft" blood prime pause commands message.

LEAHI-APPLICATION-LDT-3433-1 11 Mar 2026

email sent

LEAHI-APPLICATION-LDT-3433-1 12 Mar 2026

BN APPROVEWS

LEAHI-TD-FIRMWARE-LDT-1903-9 10 Mar 2026

Comment to right no longer makes sense.

LEAHI-TESTSUITES-LDT-3060-1 12 Mar 2026

change line of code as per comment

LEAHI-APPLICATION-LDT-2264-1 08 Oct 2025

This file does not have any accept/ reject response from FW as this only broadcasts the vitals data so it has been updated to no longer inherit VAdjustmentResponseBase. VTreatmentAdjustmentVitals.cpp/h was created to inherit VAdjustmentResponseBase and has all this when requesting the vitals data

LEAHI-APPLICATION-LDT-3433-1 10 Mar 2026

update to use VTreatmentRanges string

LEAHI-DIALIN-LDT-2264-1 10 Oct 2025

These should be the unsigned_integer_to_Bytearray

LEAHI-DD-FIRMWARE-LDT-3603-1 12 Mar 2026

You are right, (missed that while duplicating the functions)

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 08 Oct 2025

Only expose property of component, not whole component.

LEAHI-DD-FIRMWARE-LDT-3603-1 11 Mar 2026

Since both states require no special handling, remove breaks and group with default - all modes.

LEAHI-APPLICATION-LDT-1440-1 10 Oct 2025

RESOLVED

LEAHI-APPLICATION-LDT-1440-1 06 Oct 2025

Remove and hard code offset.

LEAHI-APPLICATION-LDT-1440-1 06 Oct 2025

Use _root. for screen variables to ensure proper context.

LEAHI-APPLICATION-LDT-1440-1 01 Oct 2025

Add first section for UF adjustment dialog open.

TD-LDT-1886-7 29 Sep 2025

Why is this "if" needed? For loop will not go beyond NUM_OF_VALVES.

TD-LDT-1886-7 29 Sep 2025

I think we still want a s/w fault if we get here. If stack gets corrupted, we can still get here.

TD-LDT-1886-7 29 Sep 2025

Please add s/w fault here.

LEAHI-DD-FIRMWARE-LDT-3603-1 12 Mar 2026

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

added

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

done

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

handled accordingly.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

changed.

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

Why did we change this spelling? Now it's wrong.

LEAHI-APPLICATION-LDT-3433-1 12 Mar 2026

BN approves

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

align

LEAHI-DD-FIRMWARE-LDT-3103-1 12 Mar 2026

align

LEAHI-APPLICATION-LDT-3413-1 13 Mar 2026

BN APPROVES.

LEAHI-TD-FIRMWARE-LDT-1394-1 13 Mar 2026

update the header and field comments in later commits

LEAHI-APPLICATION-LDT-3574-1 13 Mar 2026

removed

LEAHI-TD-FIRMWARE-LDT-1840-1 13 Mar 2026

Updated

LEAHI-APPLICATION-LDT-3574-1 12 Mar 2026

remove source